Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: version output is malformatted #3938

Closed
jcstein opened this issue Nov 14, 2024 · 5 comments
Closed

bug: version output is malformatted #3938

jcstein opened this issue Nov 14, 2024 · 5 comments
Assignees
Labels
area:node Node bug Something isn't working external Issues created by non node team members

Comments

@jcstein
Copy link
Member

jcstein commented Nov 14, 2024

Celestia Node version

v0.20.1

OS

mac

Install tools

docs

# clone node
make build
make install
celestia version

Others

No response

Steps to reproduce it

above

Expected result

version: v0.20.1-mocha

Actual result

$ celestia version

Semantic version: v0.18.0-refs-tags-v0-20-1-mocha.0
Commit: 353141fb5a0a33c10a8678ac6e92a90b02f74dbd
Build Date: Thu Nov 14 14:10:37 +07 2024
System version: arm64/darwin
Golang version: go1.23.2

Relevant log output

No response

Is the node "stuck"? Has it stopped syncing?

No response

Notes

No response

@jcstein jcstein added the bug Something isn't working label Nov 14, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Nov 14, 2024
@renaynay renaynay added the area:node Node label Nov 14, 2024
@cristaloleg cristaloleg self-assigned this Nov 14, 2024
@jcstein
Copy link
Member Author

jcstein commented Nov 20, 2024

This is still present on v0.20.2

/_____/  /_____/  /_____/  /_____/  /_____/
Started celestia DA node
node version:         v0.18.0-refs-tags-v0-20-2-arabica.0
node type:         bridge
network:         mocha-4
/_____/  /_____/  /_____/  /_____/  /_____/

@walldiss
Copy link
Member

Thank you for reminding of this issue. We have broken CI that produces second tag for release and it is mailformed one. I’ve deleted incorrect tags for all recent releases, so it should not be a problem for existing ones. @oleg is on the hunt to track down the root cause

@jcstein
Copy link
Member Author

jcstein commented Nov 21, 2024

you're welcome and thank you for the context and support 🙌

@cristaloleg
Copy link
Contributor

I did a test release and celestia version reports proper tag https://github.com/celestiaorg/celestia-node/releases/tag/v0.20.4-test6

$ ./celestia version
Semantic version: 0.20.4-test6
Commit: 2418898e46b468e4810b70bd56bc5bb4aa103c9a
Build Date: 2024-12-03T08:51:44Z
System version: arm64/darwin
Golang version: go1.23.3

Fixed in #3978 and closing this one.

@jcstein
Copy link
Member Author

jcstein commented Dec 3, 2024

got it. this is the only release with that commit though, so not sure this should be closed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:node Node bug Something isn't working external Issues created by non node team members
Projects
None yet
Development

No branches or pull requests

4 participants