Update golangci-lint version to v1.21.0

[woohhan]

Signed-off-by: Woohyung Han [email protected]

Describe what this PR does

Update golangci-lint version to v1.21.0

Is there anything that requires special attention

Most of issue was unnecessary trailing newline, unnecessary leading newline.

// BAD
		return err

	}
	return nil
}

// GOOD
		return err
	}
	return nil
}

I disabled following linters

1. godox: Tool for detection of FIXME, TODO and other comment keywords
2. wsl: Whitespace Linter, has assignments should only be cuddled with other assignments rule. This rule force to cuddle all assignements. (need new line after assignements). I think It's not so cool, see following example. and we have simllary linter for detecting trailing. the whitespace linter to detect leading and trailing whitespace.

// BAD (by wsl)
	_, err := framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisioner)
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner %v", err)
	}
	_, err = framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisionerRBAC)
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner rbac %v", err)
	}

// GOOD
	_, err := framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisioner)
	
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner %v", err)
	}
	
	_, err = framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisionerRBAC)
	
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner rbac %v", err)
	}

3. funlen: Tool for detection of long functions. I don't think this is needed for golang. golang has no column limit.

Related issues

Fixes: #736

Future concerns

We have one warning in the test, and this is golangci-lint issue. golangci/golangci-lint#827

WARN [runner] Can't run linter unused: buildssa: analysis skipped: errors in package: 
(...)

I'm not sure about these. Please take a look these.

• We have the gocognit lint for Computes and checks the cognitive complexity of functions. But the min-complexity value with default (30) is not passed the test for now. I think we can just disable this lint, or need to refactor to pass the lint. (maybe another pull request?)
• I found yamllint not working correctly in my desktop with following error. Perhaps we need to check this too.

yamllint -s -d {extends: default, rules: {line-length: {allow-non-breakable-inline-mappings: true}},ignore: charts/*/templates/*.yaml} ./.mergify.yml 
[DEPRECATION] The trollop gem has been renamed to optimist and will no longer be supported. Please switch to optimist as soon as possible.
Error: unknown argument '-s'.
Try --help for help.

[Madhu-1]

Signed-off-by: Woohyung Han [email protected]

Describe what this PR does

Update golangci-lint version to v1.21.0

Is there anything that requires special attention

Most of issue was unnecessary trailing newline, unnecessary leading newline.

// BAD
		return err

	}
	return nil
}

// GOOD
		return err
	}
	return nil
}

I disabled following linters

1. godox: Tool for detection of FIXME, TODO and other comment keywords
2. wsl: Whitespace Linter, has assignments should only be cuddled with other assignments rule. This rule force to cuddle all assignements. (need new line after assignements). I think It's not so cool, see following example. and we have simllary linter for detecting trailing. the whitespace linter to detect leading and trailing whitespace.

// BAD (by wsl)
	_, err := framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisioner)
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner %v", err)
	}
	_, err = framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisionerRBAC)
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner rbac %v", err)
	}

// GOOD
	_, err := framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisioner)
	
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner %v", err)
	}
	
	_, err = framework.RunKubectl("delete", "-f", cephfsDirPath+cephfsProvisionerRBAC)
	
	if err != nil {
		e2elog.Logf("failed to delete cephfs provisioner rbac %v", err)
	}

1. funlen: Tool for detection of long functions. I don't think this is needed for golang. golang has no column limit.

i think we should limit to some value (around 120), having long function is diffficult to read, can we track this in seperate issue?

Related issues

Fixes: #736

Future concerns

We have one warning in the test, and this is golangci-lint issue. golangci/golangci-lint#827

WARN [runner] Can't run linter unused: buildssa: analysis skipped: errors in package: 
(...)

as this is a golangci-lint issue once this is fixed will update to newer version

I'm not sure about these. Please take a look these.

* We have the [gocognit](https://github.com/uudashr/gocognit) lint for `Computes and checks the cognitive complexity of functions`. But the min-complexity value with default (30) is not passed the test for now. I think we can just disable this lint, or need to refactor to pass the lint. (maybe another pull request?)

as you added this as TODO this can be enabled later also.

• I found yamllint not working correctly in my desktop with following error. Perhaps we need to check this too.

yamllint -s -d {extends: default, rules: {line-length: {allow-non-breakable-inline-mappings: true}},ignore: charts/*/templates/*.yaml} ./.mergify.yml 
[DEPRECATION] The trollop gem has been renamed to optimist and will no longer be supported. Please switch to optimist as soon as possible.
Error: unknown argument '-s'.
Try --help for help.

Check yamllint version in your local system.

[Madhu-1]

LGTM Thanks @WoohyungHan

[humblec]

LGTM.. Thanks !