Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sign and Submit] Prevent users from filing if they have no TIN or inactive LEIs #1038

Open
Tracked by #281 ...
billhimmelsbach opened this issue Oct 31, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request triage tickets that need investigation to be updated or closed

Comments

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Oct 31, 2024

Current behavior

  • users can submit with inactive LEIs or absent TINs

Expected behavior

  • users should not be able to file without these two pieces of data

Closes: #280, #281

@meissadia
Copy link
Contributor

@natalia-fitzgerald @billhimmelsbach
Questions:

  • "Inactive LEI": Which LEI status indicator should we rely upon for this info since there are at least two places it is specified in the response from GET /v1/institutions/{{LEI}}
    • Status code: lei_status_code and lei_status.code, i.e. "ISSUED"
    • Status name: lei_status.name i.e. "Issued"
    • Can file: lei_status.can_file i.e. true
  • How should the page-level error alert fit with the existing "You have reached the final step of the beta filing process" warning?
    • Do we want to show this error on initial page load, if the errors exist (my current implementation)? Or do we only want to show this error after a user clicks Submit filing?
    • Screenshot:
      Screenshot 2025-01-15 at 9 54 13 AM

@meissadia meissadia added enhancement New feature or request triage tickets that need investigation to be updated or closed labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage tickets that need investigation to be updated or closed
Projects
None yet
Development

No branches or pull requests

2 participants