Support for HTTPS #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
r01k
commented
Nov 4, 2022
r01k
commented
- Added support for HTTPS.
- Optional certificate validation.
- Now defaults to connect over HTTPS with validation.
|
@cgarwood, any chance to take a look at this merge request? I have the dependent integration working over HTTPS. |
|
Since Fully Kiosk Browser's remote admin is non-https by default, I think we should still default to HTTP instead of HTTPS, but otherwise looks good 👍 |
|
@cgarwood, defaulted to HTTP as suggested. If you merge, please let me when it is published to Pypi to submit the pull request for Fully Kiosk in HA. Thanks! |
cgarwood
approved these changes
Nov 27, 2022
|
Publishing to PyPi as 0.0.12: https://github.com/cgarwood/python-fullykiosk/actions/runs/3559698634 |
JordiSaPe
pushed a commit
to JordiSaPe/python-fullykiosk
that referenced
this pull request
Jun 24, 2024
* Added support for HTTPS with optional certificate validation. * Now FullyKiosk defaults to HTTP instead of HTTPS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.