fix: usage of copts for SWIFT_PACKAGE
#1260
Conversation
This primarily does two changes: - Passes `-Xcc -DSWIFT_PACKAGE` for the Swift library target generated `copts` attribute. - Removes de-duplication in `bzl_selects.bzl` - This is required because `copts = ["-DSWIFT_PACKAGE", "-Xcc", "-DSWIFT_PACKAGE"]` are valid copts but would get de-duplicated into `copts = ["-DSWIFT_PACKAGE", "-Xcc"]` Fixes #1259
| @@ -106,6 +106,9 @@ def _swift_target_build_file(pkg_ctx, target): | |||
| # SPM directive instructing the code to build as if a Swift package. | |||
| # https://github.com/apple/swift-package-manager/blob/main/Documentation/Usage.md#packaging-legacy-code | |||
| "-DSWIFT_PACKAGE", | |||
| # SPM directive instructing the code to build as if a Swift package for any clang modules. | |||
| "-Xcc", | |||
| "-DSWIFT_PACKAGE", | |||
There was a problem hiding this comment.
I am confused. When are we building a C/C++ file with the swift compiler? We have separate targets for Swift and C/C++ source code.
There was a problem hiding this comment.
-Xcc passes a flag through to all C compiler invocations
There was a problem hiding this comment.
Sorry. Perhaps, I am missing something. We create cc_xxx, objc_xxx, and swift_xxx targets separating the source files into their respective targets. How is a C/C++ file being compiled by the Swift compiler? The cc_xxx and objc_xxx should be compiled with clang.
There was a problem hiding this comment.
When Swift depends on a clang module (modulemap and headers), with implicit modules it compiles that clang module. -Xcc is a way to pass compiler flags to that compilation.
|
Added an example repo and example in: #1261 |
|
I'll need to update this because we do want to dedupe some attrs (like deps) across configs/defaults but not copt. Going to look at making a new method for this |
This primarily does two changes:
-Xcc -DSWIFT_PACKAGEfor the Swift library target generatedcoptsattribute.bzl_selects.bzlcopts = ["-DSWIFT_PACKAGE", "-Xcc", "-DSWIFT_PACKAGE"]are valid copts but would get de-duplicated intocopts = ["-DSWIFT_PACKAGE", "-Xcc"]Fixes #1259