Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embrace-io/embrace-apple-sdk. #1279

Open
cgrindel opened this issue Oct 5, 2024 · 6 comments · May be fixed by #1278
Open

Support embrace-io/embrace-apple-sdk. #1279

cgrindel opened this issue Oct 5, 2024 · 6 comments · May be fixed by #1278
Labels
enhancement New feature or request

Comments

@cgrindel
Copy link
Owner

cgrindel commented Oct 5, 2024

Related Slack thread.

There are two issues:

  1. The EmbraceObjCUtilsInternal module has two module map files. The existing rules_swift_package_manager code treats this as an error. The fix is to warn the client and just use the first one that is found.
  2. The GRDB.swift package, a transitive dependency, defines a systemLibrary target. rules_swift_package_manager does not yet support these target types.
@cgrindel cgrindel added the enhancement New feature or request label Oct 5, 2024
@cgrindel cgrindel linked a pull request Oct 5, 2024 that will close this issue
@adincebic
Copy link
Contributor

@cgrindel what does it take to support packages with system library targets? Is the change complex?

@cgrindel
Copy link
Owner Author

what does it take to support packages with system library targets? Is the change complex?

Probably not. I have not dug into it. I would look at how SPM builds targets linked to these libraries. There is a flag which tells SPM to output its build commands. Then, it is a matter of generating the appropriate targets here.

@luispadron
Copy link
Collaborator

Related to #248

@adincebic
Copy link
Contributor

I'll have some time next weekend to attend this issue. Thank you both for references.

@lucasmarcal-faire
Copy link
Contributor

SystemLibrary Support Draft PR: #1323

@luispadron
Copy link
Collaborator

luispadron commented Nov 12, 2024

Duplicate of #248, thanks for working on this @lucasmarcal-faire!

edit: ah I see theres two issues tied with this one

@luispadron luispadron closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
@luispadron luispadron reopened this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants