Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support system target types #248

Open
cgrindel opened this issue Feb 28, 2023 · 3 comments · May be fixed by #1323
Open

Support system target types #248

cgrindel opened this issue Feb 28, 2023 · 3 comments · May be fixed by #1323
Labels
enhancement New feature or request
Milestone

Comments

@cgrindel
Copy link
Owner

Looking for a popular package that leverages system targets (i.e, systemLibrary).

#235 was reported as a failure to support system targets. However, it turns out that the real issue was that targets were not being properly filtered out before build file generation. For instance, test targets and targets only associated with phantom products should not be built.

@cgrindel cgrindel added the enhancement New feature or request label Feb 28, 2023
@cgrindel cgrindel added this to the Release 0.4.0 milestone Feb 28, 2023
@denis15yo
Copy link

Hi! What about https://github.com/groue/GRDB.swift ?

@cgrindel
Copy link
Owner Author

@denis15yo Cool. Thanks. I will try to pick this up in the next couple of weeks.

@luispadron
Copy link
Collaborator

luispadron commented Sep 15, 2024

This is a minimal BUILD file it seems we would need to get something like CSQLite generated (this is used in GRDB.swift for example):

load("@rules_cc//cc:defs.bzl", "cc_library")
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library_group", "swift_interop_hint")

swift_library_group(
    name = "CSQLite",
    deps = [
        ":CSQLite_system_library",
    ],
)

cc_library(
    name = "CSQLite_system_library",
    hdrs = ["shim.h"],
    aspect_hints = [":CSQLite_swift_interop"],
)

swift_interop_hint(
    name = "CSQLite_swift_interop",
    module_map = "module.modulemap",
    module_name = "CSQLite",
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants