Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add necessary parameters to errors in smart contracts #338

Closed
thedevbirb opened this issue Oct 29, 2024 · 1 comment
Closed

Add necessary parameters to errors in smart contracts #338

thedevbirb opened this issue Oct 29, 2024 · 1 comment
Labels
C: smart-contracts Component: smart contracts
Milestone
v0.5

Comments

@thedevbirb
Copy link
Contributor

Currently some errors in BoltValidatorsV1 like ValidatorDoesNotExist or ValidatorAlreadyExists do not take any argument which makes hard to debug which validator public key is actually not correct, especially in batch calls like getProposerStatuses

Ideally all similar errors should be parametric.
@thedevbirb thedevbirb added the C: smart-contracts Component: smart contracts label Oct 29, 2024
@thedevbirb thedevbirb added this to the v0.4: Holesky 2 milestone Oct 29, 2024
@merklefruit merklefruit mentioned this issue Oct 29, 2024
Merged
@thedevbirb
Copy link
Contributor Author

Closed by #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: smart-contracts Component: smart contracts
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
1 participant
@thedevbirb