Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify authorization schema for builders #41

Closed
thedevbirb opened this issue May 29, 2024 · 1 comment · Fixed by #187
Closed

Specify authorization schema for builders #41

thedevbirb opened this issue May 29, 2024 · 1 comment · Fixed by #187
Assignees
Labels
A: docs Area: Documentation C: block-builder Component: block builder C: mev-boost-relay Component: mev-boost-relay T: discussion Type: Discussion
Milestone

Comments

@thedevbirb
Copy link
Contributor

thedevbirb commented May 29, 2024

Builders need to authenticate when subscribing to SSE events emitted from relays. Right now in the codebase we're using a string like this:

"BOLT \"<signature>\",{\"publicKey\":\"<builder_pub_key>\",\"slot\":<slot>}"

where signature refers to the JSON-stringified object appearing the in the authentication message.
However, we should discuss more about it and update the specs.

The rationale for this schema is to have a simple one that included the builder public key, a nonce-like number to avoid replay attacks and a signature

@thedevbirb thedevbirb added A: docs Area: Documentation C: mev-boost-relay Component: mev-boost-relay C: block-builder Component: block builder T: discussion Type: Discussion labels May 29, 2024
@thedevbirb thedevbirb added this to the v0.1 milestone May 29, 2024
@thedevbirb thedevbirb modified the milestones: v0.1, v0.2 Jun 4, 2024
@merklefruit merklefruit self-assigned this Aug 6, 2024
@merklefruit
Copy link
Collaborator

Update: we have decided to remove authorization for this endpoint, as heavy rate-limiting will be enough to prevent major dos attacks on relays.

This task is now changing to "remove builder auth"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: Documentation C: block-builder Component: block builder C: mev-boost-relay Component: mev-boost-relay T: discussion Type: Discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants