Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple pricing logic from validate_min_priority_fee #648

Open
estensen opened this issue Jan 8, 2025 · 2 comments
Open

Decouple pricing logic from validate_min_priority_fee #648

estensen opened this issue Jan 8, 2025 · 2 comments
Assignees
Labels
D-good-first-issue Difficulty: a great choice to get started!

Comments

@estensen
Copy link
Contributor

estensen commented Jan 8, 2025

Revert back to this implementation and move pricing logic to ExecutionState

pub fn validate_min_priority_fee(&self, max_base_fee: u128, min_priority_fee: u128) -> bool {
self.txs.iter().all(|tx| {
tx.effective_tip_per_gas(max_base_fee).map_or(false, |tip| tip >= min_priority_fee)
})
}

@estensen estensen added the D-good-first-issue Difficulty: a great choice to get started! label Jan 8, 2025
@faheelsattar
Copy link
Contributor

Hey! can i pick this?

@estensen
Copy link
Contributor Author

estensen commented Jan 9, 2025

@faheelsattar yes, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-good-first-issue Difficulty: a great choice to get started!
Projects
None yet
Development

No branches or pull requests

2 participants