Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented triangle functions #224

Merged
merged 1 commit into from
Aug 19, 2019
Merged

implemented triangle functions #224

merged 1 commit into from
Aug 19, 2019

Conversation

durswd
Copy link
Contributor

@durswd durswd commented Aug 16, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 17, 2019

Codecov Report

Merging #224 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   90.22%   90.39%   +0.16%     
==========================================
  Files          24       24              
  Lines        1555     1582      +27     
==========================================
+ Hits         1403     1430      +27     
  Misses        152      152
Impacted Files Coverage Δ
onnx_chainer/mapping.py 90% <ø> (ø) ⬆️
onnx_chainer/functions/__init__.py 100% <100%> (ø) ⬆️
onnx_chainer/functions/math.py 87% <100%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eebbf2...9cebb92. Read the comment docs.

@disktnk disktnk added this to the 1.5.1 milestone Aug 17, 2019
@disktnk disktnk self-requested a review August 17, 2019 16:32
@disktnk
Copy link
Member

disktnk commented Aug 17, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 3e193e3:

Copy link
Member

@disktnk disktnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Please keep function names in mapping.py alphabetical order. README.md is reorganized in next release, so you don't have to care.

@durswd
Copy link
Contributor Author

durswd commented Aug 19, 2019

I fixed it

@disktnk disktnk merged commit 8de1ef3 into chainer:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants