Allow testing on linux using a custom TEST_LIBSECP256K1_PATH #70
Conversation
| @@ -112,6 +112,10 @@ Therefore, some tests require this library. In a Linux environment, `spec/lib/li | |||
| so there is no need to do anything. If you want to test in another environment, | |||
| please set the library path in the environment variable `TEST_LIBSECP256K1_PATH`. | |||
|
|
|||
| In case the supplied linux `spec/lib/libsecp256k1.so` is not working (architecture), you might have to compile it yourself. | |||
| Since if available in the repository, it might not be compiled using the `./configure --enable-module-recovery` option. | |||
There was a problem hiding this comment.
Library in this repository support --enable-module-recovery. Basically, all functions attached by the following methods are enabled.
https://github.com/chaintope/bitcoinrb/blob/master/lib/bitcoin/secp256k1/native.rb#L40-L67
There was a problem hiding this comment.
I think that the included library in the specs is built in an x86-64 architecture. I'm using an Apple M1 having a Fedora linux (ARM). It all runs, which is nice. The library is even is available through package management:
sudo dnf install libsecp256k1
But linking to this install gives an error on the secp256k1_ecdsa_sign_recoverable attachment. Therefor compiling using de recorery flag was my solution to make all tests pass. Probable there is a better solution, but I did not find it.
There was a problem hiding this comment.
I see, repository means package manager, not this github repository. In that case, --enable-module-ellswift may not be used either.
There was a problem hiding this comment.
To get the tests to run on my local machine was more trial and error than knowledge. The supplied library placed in: spec/lib/libsecp256k1.so crashes on the ffi_lib(ENV['SECP256K1_LIB_PATH']) statement in: lib/bitcoin/secp256k1/native.rb.
So I decided to build it myself. Therefore I used the README.md from bitcoin-core/secp256k1 that is nice and clear to build. Although finding the libs in a hidden .libs folder was a bit of a surprise.
Without configuration flags the compiled libsecp256k1 gives the following error while loading native:
Function 'secp256k1_ecdsa_sign_recoverable' not found
It took me a while to figure out that this could be resolved by compiling using a different configuration. So also put a note in the README.md to help others find the solution faster if they run into this problem.
What the required/recommended configure flags are I don't know. This worked for me to get all the tests green. So a correct statement from an expert on how to compile would be great. I'll post a partial output from the default at the moment below.
Build Options:
with external callbacks = no
with benchmarks = yes
with tests = yes
with ctime tests = no
with coverage = no
with examples = no
module ecdh = yes
module recovery = no
module extrakeys = yes
module schnorrsig = yes
module ellswift = yes
asm = no
ecmult window size = 15
ecmult gen table size = 22 KiB
valgrind = no
CC = gcc
CPPFLAGS =
There was a problem hiding this comment.
I was mistaken and ellswift was also enabled. thanks!
When running the specs on an Apple M1 machine running Fedora linux there were some problems using the secp256k1 library. The changes of this request should allow running all the specs on these (and other) type of linux machines.