Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomics.wake(...) always returns 0 on non-win32 platforms #5368

Open
rwaldron opened this issue Jun 26, 2018 · 1 comment
Open

Atomics.wake(...) always returns 0 on non-win32 platforms #5368

rwaldron opened this issue Jun 26, 2018 · 1 comment

Comments

@rwaldron
Copy link

While working on Atomics tests for Test262, I observed that any test which checked that the return value of Atomics.wake(...) was some non-zero value, the test would fail. I've tracked the cause:

https://github.com/Microsoft/ChakraCore/blob/c0723f4985c468937c6ac12260bdbe5da6d25539/lib/Runtime/Library/SharedArrayBuffer.cpp#L764-L780

@dilijev dilijev added this to the vNext milestone Jun 26, 2018
@fatcerberus
Copy link
Contributor

On a related tangent, TC39 has apparently agreed to rename Atomics.wake to Atomics.notify. See, e.g. this Node.js issue:
nodejs/node#21219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants