Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Dataset Part 4 [Delete Dataset/Cancel Upload] #706

Closed
tihuan opened this issue Nov 10, 2020 · 1 comment · Fixed by #839
Closed

Upload Dataset Part 4 [Delete Dataset/Cancel Upload] #706

tihuan opened this issue Nov 10, 2020 · 1 comment · Fixed by #839
Assignees
Labels
frontend Frontend work

Comments

@tihuan
Copy link
Contributor

tihuan commented Nov 10, 2020

Design: https://www.figma.com/file/g0L0CfVzRc8r6HQa4NH1wJ/Publisher-Collection?node-id=493%3A225

What:

After finishing this PART 4 ticket, the user will be able to delete/cancel a dataset

Delete Dataset
No need to do delete collection

Screen Shot 2020-11-10 at 11.11.16 AM.png

  1. Render the dataset entry as a row, as shown in design here -- Please double check with @hthomas-czi this is the correct design 🙏

  2. API doc is here - to delete a dataset, call the DELETE endpoint

  3. BE tickets here

User Flows:

  1. Notice that the trash can button at the dataset row, on hover will expand and show text "Delete" in addition to the icon (please reach out to Harley if the mock doesn't reflect this hover behavior)

  2. On trash can / delete button click, we show a confirmation modal as a checkpoint

  3. Once user decides again to delete, we send a POST call to backend. If we get success response, we refetch all datasets, and the pending delete dataset should no longer be displayed

  4. Please note that since cancel also hits the same DELETE endpoint, we'll also implement the cancel flow in this ticket!

@tihuan tihuan added the frontend Frontend work label Nov 10, 2020
@tihuan tihuan changed the title Dropbox Integration for Upload Dataset Part 4 [Delete Dataset] Dropbox Integration for Upload Dataset Part 4 [Delete/Cancel Dataset] Nov 10, 2020
@brianraymor brianraymor changed the title Dropbox Integration for Upload Dataset Part 4 [Delete/Cancel Dataset] Upload Dataset Part 4 [Delete Dataset/Cancel Upload] Nov 10, 2020
@brianraymor
Copy link

Refinement note from @tihuan - 706 (Delete / Cancel Dataset) has a slight coupling with 705, because of the conversion cancellation trash can. But I think all three tickets can still be done in parallel, and I can create an integration ticket between 705 and 706 for 1 point, if we end up parallelizing 705 and 706!

@brianraymor brianraymor added this to the 2021 Jan 8 - Jan 21 milestone Jan 7, 2021
@seve seve self-assigned this Jan 12, 2021
@tihuan tihuan linked a pull request Jan 21, 2021 that will close this issue
@maniarathi maniarathi reopened this Jan 21, 2021
@MDunitz MDunitz closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants