From bbf51b0c05fd6ec82edb15685b23678896c87b17 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 20 Jan 2023 19:17:24 +0000 Subject: [PATCH 1/5] chore(deps): bump decode-uri-component from 0.2.0 to 0.2.2 in /client (#543) Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Trent Smith <1429913+Bento007@users.noreply.github.com> --- client/package-lock.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/client/package-lock.json b/client/package-lock.json index 832b77640..56ddae07e 100644 --- a/client/package-lock.json +++ b/client/package-lock.json @@ -8387,9 +8387,9 @@ "dev": true }, "node_modules/decode-uri-component": { - "version": "0.2.0", - "resolved": "https://registry.npmjs.org/decode-uri-component/-/decode-uri-component-0.2.0.tgz", - "integrity": "sha512-hjf+xovcEn31w/EUYdTXQh/8smFL/dzYjohQGEIgjyNavaJfBY2p5F527Bo1VPATxv0VYTUC2bOcXvqFwk78Og==", + "version": "0.2.2", + "resolved": "https://registry.npmjs.org/decode-uri-component/-/decode-uri-component-0.2.2.tgz", + "integrity": "sha512-FqUYQ+8o158GyGTrMFJms9qh3CqTKvAqgqsTnkLI8sKu0028orqBhxNMFkFen0zGyg6epACD32pjVk58ngIErQ==", "dev": true, "engines": { "node": ">=0.10" @@ -27088,9 +27088,9 @@ "dev": true }, "decode-uri-component": { - "version": "0.2.0", - "resolved": "https://registry.npmjs.org/decode-uri-component/-/decode-uri-component-0.2.0.tgz", - "integrity": "sha512-hjf+xovcEn31w/EUYdTXQh/8smFL/dzYjohQGEIgjyNavaJfBY2p5F527Bo1VPATxv0VYTUC2bOcXvqFwk78Og==", + "version": "0.2.2", + "resolved": "https://registry.npmjs.org/decode-uri-component/-/decode-uri-component-0.2.2.tgz", + "integrity": "sha512-FqUYQ+8o158GyGTrMFJms9qh3CqTKvAqgqsTnkLI8sKu0028orqBhxNMFkFen0zGyg6epACD32pjVk58ngIErQ==", "dev": true }, "decompress-response": { From 23477dda09bdb2d0426997f0e586ee4ad93b20c8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 20 Jan 2023 22:09:45 +0000 Subject: [PATCH 2/5] chore(deps): bump loader-utils from 2.0.2 to 2.0.4 in /client (#536) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](https://github.com/webpack/loader-utils/compare/v2.0.2...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Trent Smith <1429913+Bento007@users.noreply.github.com> --- client/package-lock.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/client/package-lock.json b/client/package-lock.json index 56ddae07e..807a680c4 100644 --- a/client/package-lock.json +++ b/client/package-lock.json @@ -13868,9 +13868,9 @@ } }, "node_modules/loader-utils": { - "version": "2.0.2", - "resolved": "https://registry.npmjs.org/loader-utils/-/loader-utils-2.0.2.tgz", - "integrity": "sha512-TM57VeHptv569d/GKh6TAYdzKblwDNiumOdkFnejjD0XwTH87K90w3O7AiJRqdQoXygvi1VQTJTLGhJl7WqA7A==", + "version": "2.0.4", + "resolved": "https://registry.npmjs.org/loader-utils/-/loader-utils-2.0.4.tgz", + "integrity": "sha512-xXqpXoINfFhgua9xiqD8fPFHgkoq1mmmpE92WlDbm9rNRd/EbRb+Gqf908T2DMfuHjjJlksiK2RbHVOdD/MqSw==", "dev": true, "dependencies": { "big.js": "^5.2.2", @@ -31293,9 +31293,9 @@ "dev": true }, "loader-utils": { - "version": "2.0.2", - "resolved": "https://registry.npmjs.org/loader-utils/-/loader-utils-2.0.2.tgz", - "integrity": "sha512-TM57VeHptv569d/GKh6TAYdzKblwDNiumOdkFnejjD0XwTH87K90w3O7AiJRqdQoXygvi1VQTJTLGhJl7WqA7A==", + "version": "2.0.4", + "resolved": "https://registry.npmjs.org/loader-utils/-/loader-utils-2.0.4.tgz", + "integrity": "sha512-xXqpXoINfFhgua9xiqD8fPFHgkoq1mmmpE92WlDbm9rNRd/EbRb+Gqf908T2DMfuHjjJlksiK2RbHVOdD/MqSw==", "dev": true, "requires": { "big.js": "^5.2.2", From f904ef6f7f1ed45f442b96bf37d891142317f15d Mon Sep 17 00:00:00 2001 From: Andrew Tolopko Date: Fri, 3 Feb 2023 16:03:54 -0500 Subject: [PATCH 3/5] chore: Update license copyright year (#557) --- LICENSE.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE.txt b/LICENSE.txt index b5a3f8120..143218c5e 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -1,6 +1,6 @@ The MIT License (MIT) -Copyright (c) 2017-2022 Chan Zuckerberg Initiative +Copyright (c) 2017-2023 Chan Zuckerberg Initiative Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in From 79b42e0222afb86fc3a69153696f67fc1c52e6d8 Mon Sep 17 00:00:00 2001 From: ashin-czi <109984998+ashin-czi@users.noreply.github.com> Date: Tue, 7 Feb 2023 10:00:46 -0500 Subject: [PATCH 4/5] fix: linting (#559) * fix: linting --- server/common/compute/estimate_distribution.py | 2 +- server/common/config/app_config.py | 1 - server/common/rest.py | 2 +- server/dataset/cxg_util.py | 1 - 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/server/common/compute/estimate_distribution.py b/server/common/compute/estimate_distribution.py index 42597c947..787232631 100644 --- a/server/common/compute/estimate_distribution.py +++ b/server/common/compute/estimate_distribution.py @@ -76,7 +76,7 @@ def estimate_approximate_distribution(X) -> XApproximateDistribution: if Xdata.size > CHUNKSIZE: min_val = max_val = Xdata[0] with concurrent.futures.ThreadPoolExecutor() as tp: - for (_min, _max) in tp.map(min_max, [Xdata[i : i + CHUNKSIZE] for i in range(0, Xdata.size, CHUNKSIZE)]): + for _min, _max in tp.map(min_max, [Xdata[i : i + CHUNKSIZE] for i in range(0, Xdata.size, CHUNKSIZE)]): min_val = min(_min, min_val) max_val = max(_max, max_val) diff --git a/server/common/config/app_config.py b/server/common/config/app_config.py index 8f1ae176b..7bfa650cf 100644 --- a/server/common/config/app_config.py +++ b/server/common/config/app_config.py @@ -31,7 +31,6 @@ class AppConfig(object): """ def __init__(self, config_file_path: str = None): - # the default configuration (see default_config.py) self.default_config: dict = get_default_config() # TODO @madison -- if we always read from the default config (hard coded path) can we set those values as diff --git a/server/common/rest.py b/server/common/rest.py index bc78ee689..a7df2e275 100644 --- a/server/common/rest.py +++ b/server/common/rest.py @@ -385,7 +385,7 @@ def summarizeQueryHash(raw_query): HTTPStatus.OK, {"Content-Type": "application/octet-stream"}, ) - except (ValueError) as e: + except ValueError as e: return abort(HTTPStatus.NOT_FOUND, description=str(e)) except (UnsupportedSummaryMethod, FilterError) as e: return abort(HTTPStatus.BAD_REQUEST, description=str(e)) diff --git a/server/dataset/cxg_util.py b/server/dataset/cxg_util.py index 53ca46b69..6cd60329c 100644 --- a/server/dataset/cxg_util.py +++ b/server/dataset/cxg_util.py @@ -18,7 +18,6 @@ def pack_selector_from_mask(boolarray): def pack_selector_from_indices(selector): - if len(selector) == 0: return None From 65b38904383da2c56140f34a0d68490950db18da Mon Sep 17 00:00:00 2001 From: Kuni Katsuya Date: Tue, 7 Feb 2023 10:20:44 -0800 Subject: [PATCH 5/5] chore: Added tech issue template (#560) --- .github/ISSUE_TEMPLATE/tech-issue.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/tech-issue.md diff --git a/.github/ISSUE_TEMPLATE/tech-issue.md b/.github/ISSUE_TEMPLATE/tech-issue.md new file mode 100644 index 000000000..4965be8c6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/tech-issue.md @@ -0,0 +1,23 @@ +--- +name: Tech Issue +about: Engineering-specific technical work that is not product-specific. Engineering team "owns" these issues. +title: "" +labels: tech +assignees: "" +--- + +## Motivation + +Why is this work important to engineers? + +## Definition of Done + +What should the end result look like? What will have been changed? + +## Tasks + +Detail the specific tasks that can be used to accomplish the desired changes. +If detailed steps cannot be provided at this time, please file a [Tech Proposal](https://docs.google.com/document/d/1o2vuvl-kXwRJN1nBoPzJS_MAQgDGYnjmPZWa4qRDi-I/edit#heading=h.7dvzhm7gqc3v) instead. + +- [ ] +- [ ]