Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1001 No download image for minimized panel #1004

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Jun 24, 2024

closes #1001

  1. This PR addresses the comment by @ainfeld and @niknak33 that when the side panel is open BUT minimized, we should not download its image (slack)

@tihuan tihuan changed the title fix: No download image for minimized panel fix: 1001 No download image for minimized panel Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (0d204de) to head (8eeeb7e).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
- Coverage   77.47%   77.08%   -0.40%     
==========================================
  Files          88       88              
  Lines        6856     6930      +74     
==========================================
+ Hits         5312     5342      +30     
- Misses       1544     1588      +44     
Flag Coverage Δ
frontend 77.08% <ø> (-0.40%) ⬇️
javascript 77.08% <ø> (-0.40%) ⬇️
smokeTest ?
unitTest 77.08% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tihuan tihuan merged commit db0944e into main Jun 24, 2024
26 checks passed
@tihuan tihuan deleted the thuang-no-download-for-minimized-side-panel branch June 24, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimized side embedding should NOT download image
1 participant