Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove spatial feature flag #1015

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Jul 2, 2024

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
DO NOT MERGE THIS PR UNTIL WE GET THE GREEN LIGHT 🚦
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

@tihuan tihuan marked this pull request as draft July 2, 2024 18:21
@tihuan tihuan force-pushed the thuang-remove-spatial-feature-flag branch from 0340256 to 6ccb9ca Compare July 2, 2024 18:22
@tihuan tihuan force-pushed the thuang-remove-spatial-feature-flag branch from 6ccb9ca to a64d613 Compare August 6, 2024 16:16
@@ -278,25 +277,25 @@ const MenuBar = ({
data-testid="drawer"
/>
</ButtonGroup>
{isDownload && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more conditional rendering on the download button

client/src/components/menubar/style.ts Show resolved Hide resolved
@tihuan tihuan requested review from rainandbare and kaloster August 6, 2024 16:19
@tihuan tihuan changed the title DO NOT MERGE - feat: Remove spatial feature flag feat: Remove spatial feature flag Aug 6, 2024
Copy link
Contributor

@rainandbare rainandbare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left a suggestion with the appropriate break points.

client/src/components/menubar/style.ts Show resolved Hide resolved
@tihuan tihuan marked this pull request as ready for review August 7, 2024 14:05
@tihuan tihuan force-pushed the thuang-remove-spatial-feature-flag branch from 7a067e4 to 4c68c4d Compare August 7, 2024 14:07
@tihuan tihuan merged commit f95a8c1 into main Aug 7, 2024
20 of 21 checks passed
@tihuan tihuan deleted the thuang-remove-spatial-feature-flag branch August 7, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants