Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the wrong lasso in the other panel #1035

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Jul 12, 2024

  1. Add graphId to lasso selection reducer state
  2. Use the new graphId to determine whether to display the lasso element in the panel or not
  3. We only display the lasso element in the panel that initiated the lasso
Screenshot 2024-07-12 at 12 01 52 PM
Screen.Recording.2024-07-12.at.11.59.48.AM.mov

@tihuan tihuan requested a review from kaloster July 12, 2024 18:58
@tihuan tihuan force-pushed the thuang-fix-lasso-in-panel branch from 4f1509d to 26c7759 Compare July 12, 2024 18:58
@tihuan
Copy link
Contributor Author

tihuan commented Jul 12, 2024

e2e tests passed locally. Will merge after it passes in GHA!

@tihuan tihuan merged commit 9dffc9e into main Jul 12, 2024
18 of 19 checks passed
@tihuan tihuan deleted the thuang-fix-lasso-in-panel branch July 12, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants