feat: cell type info and info panel refactor #1043

kaloster · 2024-07-18T21:06:33Z

Adding Cell Type to the info panel #1050

rdev -> here

codecov · 2024-07-19T19:47:25Z

Codecov Report

Attention: Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (97f57e6) to head (dc5d162).
Report is 13 commits behind head on main.

Files	Patch %	Lines
server/common/rest.py	70.83%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   77.43%   77.57%   +0.13%     
==========================================
  Files          90       92       +2     
  Lines        7010     7116     +106     
==========================================
+ Hits         5428     5520      +92     
- Misses       1582     1596      +14

Flag	Coverage Δ
frontend	`77.57% <86.79%> (+0.13%)`	⬆️
javascript	`77.57% <86.79%> (+0.13%)`	⬆️
unitTest	`77.57% <86.79%> (+0.13%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kaloster · 2024-07-22T21:30:00Z

client/__tests__/e2e/e2e.test.ts

@@ -1382,6 +1385,9 @@ for (const testDataset of testDatasets) {
              test("open info panel and hide/remove", async ({
                page,
              }, testInfo) => {
+                skipIfSidePanel(graphTestId, MAIN_PANEL);
+                skipIfPbmcDataset(testDataset, DATASET);


Skipping for pbmc3k.cxg dataset as there is no cell_type category

Great context! Can we add that as code comment please?

Also I added an item in the Q3 list to consolidate e2e test dataset to just hopefully one, so we don't have to deal with so many different test datasets 😆

kaloster · 2024-07-22T21:33:24Z

client/src/components/geneExpression/infoPanel/common/infoPanelContainer/index.tsx

+} from "../infoPanelParts";
+import { ExtendedInfoProps } from "../types";
+
+function ContainerInfo(props: ExtendedInfoProps) {


Common container for either Gene Info or Cell Type Info

Great extraction 👏

tihuan · 2024-07-23T15:27:08Z

Quick feedback on styling, the cell type row seems to be taller compared to the author category items now, maybe we can lower the min-height/width from 24 to 18px or something?

BEFORE (24px)

AFTER (18px)

Video:

Screen.Recording.2024-07-23.at.8.27.28.AM.mov

CC: @hthomas-czi to see what you think!

tihuan

Overall looks super good! Thanks so much, @kaloster 🚀 Just some small nits otherwise LGTM!

tihuan · 2024-07-23T16:56:02Z

client/__tests__/e2e/e2e.test.ts

@@ -1382,6 +1385,9 @@ for (const testDataset of testDatasets) {
              test("open info panel and hide/remove", async ({
                page,
              }, testInfo) => {
+                skipIfSidePanel(graphTestId, MAIN_PANEL);
+                skipIfPbmcDataset(testDataset, DATASET);


Great context! Can we add that as code comment please?

tihuan · 2024-07-23T17:04:04Z

client/src/common/types/entities.ts

@@ -143,3 +143,30 @@ export interface PublisherMetadata {
  published_month: number;
  published_year: number;
 }
+
+export interface CellInfo {


awesome types man!

client/src/components/geneExpression/gene.tsx

tihuan · 2024-07-23T17:06:23Z

client/src/components/geneExpression/infoPanel/common/infoPanelContainer/index.tsx

+} from "../infoPanelParts";
+import { ExtendedInfoProps } from "../types";
+
+function ContainerInfo(props: ExtendedInfoProps) {


Great extraction 👏

client/src/components/geneExpression/infoPanel/common/infoPanelContainer/index.tsx

client/src/components/geneExpression/infoPanel/connect.ts

client/src/reducers/controls.ts

client/src/actions/index.ts

client/src/components/geneExpression/infoPanel/types.ts

tihuan

One tiny comment then LGTM!! Sorry 😆

client/src/components/geneExpression/infoPanel/connect.ts

kaloster and others added 5 commits July 18, 2024 17:05

feat: cell type info and info panel refactor

543642f

chore: Updated [rdev] values.yaml image tags to sha-543642f3

1fd5909

chore: style cleanup and constants

6548442

chore: Updated [rdev] values.yaml image tags to sha-6548442e

3ea8d5d

Merge branch 'main' into kaloster/cell-type-info

0ba7d94

kaloster added the stack label Jul 19, 2024

kaloster force-pushed the kaloster/cell-type-info branch from 39d7cd2 to 0245fd4 Compare July 19, 2024 20:36

fix: mypy typing

ddc0fec

kaloster force-pushed the kaloster/cell-type-info branch from 61b5dad to ddc0fec Compare July 19, 2024 21:01

Merge branch 'main' into kaloster/cell-type-info

cd60fde

kaloster force-pushed the kaloster/cell-type-info branch 2 times, most recently from 7b794ab to 68af505 Compare July 20, 2024 00:15

fix: existing tests after refactor

50dae4e

kaloster force-pushed the kaloster/cell-type-info branch from a61305a to 50dae4e Compare July 20, 2024 00:29

kaloster and others added 3 commits July 20, 2024 00:37

chore: Updated [rdev] values.yaml image tags to sha-50dae4ef

04ccae5

chore: e2e and unit tests

c36b9bf

Merge branch 'main' into kaloster/cell-type-info

da9947f

kaloster commented Jul 22, 2024

View reviewed changes

fix: error handling and tweaks

dc6815e

kaloster force-pushed the kaloster/cell-type-info branch from 023298f to dc6815e Compare July 22, 2024 22:12

chore: Updated [rdev] values.yaml image tags to sha-dc6815ed

3882bc0

kaloster marked this pull request as ready for review July 22, 2024 22:18

kaloster requested review from tihuan, rainandbare and atarashansky July 22, 2024 22:21

kaloster and others added 3 commits July 23, 2024 01:35

fix: some visual tweaks

4f1d534

chore: Updated [rdev] values.yaml image tags to sha-4f1d534a

136d8c0

fix: selected point size

9a210ab

chore: Updated [rdev] values.yaml image tags to sha-9a210aba

d9777c1

tihuan and others added 3 commits July 23, 2024 08:45

fix: Update SDS theme font to Roboto Condensed

23f53c6

chore: font cleanup

a6dc7df

chore: Updated [rdev] values.yaml image tags to sha-a6dc7df8

3579de2

tihuan reviewed Jul 23, 2024

View reviewed changes

kaloster added 2 commits July 23, 2024 14:46

fix: address feedback

cdc787e

fix: address feedback

8857820

kaloster commented Jul 23, 2024

View reviewed changes

client/src/reducers/controls.ts Show resolved Hide resolved

kaloster commented Jul 23, 2024

View reviewed changes

client/src/actions/index.ts Show resolved Hide resolved

kaloster requested a review from tihuan July 23, 2024 18:52

kaloster added 3 commits July 23, 2024 18:56

chore: Updated [rdev] values.yaml image tags to sha-88578202

6064234

Merge branch 'main' into kaloster/cell-type-info

ba17a04

chore: Updated [rdev] values.yaml image tags to sha-ba17a049

4f8f19f

tihuan reviewed Jul 23, 2024

View reviewed changes

client/src/components/geneExpression/infoPanel/types.ts Outdated Show resolved Hide resolved

fix: remove enum

48718b8

kaloster requested a review from tihuan July 23, 2024 21:44

Merge branch 'main' into kaloster/cell-type-info

da9ec60

tihuan approved these changes Jul 23, 2024

View reviewed changes

client/src/components/geneExpression/infoPanel/connect.ts Outdated Show resolved Hide resolved

chore: update types

bf4bef9

kaloster force-pushed the kaloster/cell-type-info branch from dc5d162 to bf4bef9 Compare July 23, 2024 22:15

kaloster enabled auto-merge (squash) July 23, 2024 22:16

chore: Updated [rdev] values.yaml image tags to sha-bf4bef92

f3a8ba1

kaloster merged commit f4ddb1a into main Jul 23, 2024
18 of 19 checks passed

kaloster deleted the kaloster/cell-type-info branch July 23, 2024 22:44

czi-github-helper bot mentioned this pull request Jul 23, 2024

chore(main): release 1.2.0 #1044

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cell type info and info panel refactor #1043

feat: cell type info and info panel refactor #1043

kaloster commented Jul 18, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jul 19, 2024 •

edited

Loading

kaloster Jul 22, 2024

tihuan Jul 23, 2024

tihuan Jul 23, 2024

kaloster Jul 22, 2024

tihuan Jul 23, 2024

tihuan commented Jul 23, 2024 •

edited

Loading

tihuan left a comment

tihuan Jul 23, 2024

tihuan Jul 23, 2024

tihuan Jul 23, 2024

tihuan left a comment

feat: cell type info and info panel refactor #1043

feat: cell type info and info panel refactor #1043

Conversation

kaloster commented Jul 18, 2024 • edited by github-actions bot Loading

codecov bot commented Jul 19, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tihuan commented Jul 23, 2024 • edited Loading

tihuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tihuan left a comment

Choose a reason for hiding this comment

kaloster commented Jul 18, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jul 19, 2024 •

edited

Loading

tihuan commented Jul 23, 2024 •

edited

Loading