Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove .happy directory and happy-related GH Actions #1052

Merged
merged 9 commits into from
Jul 29, 2024
Merged

chore: remove .happy directory and happy-related GH Actions #1052

merged 9 commits into from
Jul 29, 2024

Conversation

hspitzley-czi
Copy link
Contributor

@hspitzley-czi hspitzley-czi commented Jul 24, 2024 •
edited
Loading

  • Removes .happy directory
  • Removes happy build/deploy GH Actions
  • Removes Happy-related env vars from Docker
    • Replaces the sha env var with a functional equivalent
    • DEPLOYMENT_STAGE is already specified in .infra values files
    • Remove other env vars without replacement , as they were not used in code

@hspitzley-czi hspitzley-czi marked this pull request as ready for review July 24, 2024 17:45
tihuan
tihuan approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR!!

@hspitzley-czi hspitzley-czi enabled auto-merge (squash) July 29, 2024 15:21
@hspitzley-czi hspitzley-czi merged commit 0b5eee9 into main Jul 29, 2024
20 of 21 checks passed
@hspitzley-czi hspitzley-czi deleted the CCIE-2817-remove-happy-directory-and-happy-related-gh-actions branch July 29, 2024 15:38
@czi-github-helper czi-github-helper bot mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan tihuan approved these changes

@jakeyheath jakeyheath jakeyheath approved these changes

@ebezzi ebezzi Awaiting requested review from ebezzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hspitzley-czi @tihuan @jakeyheath