Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade MUI and SDS - SCE-3 SCE-2 #1075

Merged
merged 7 commits into from
Aug 20, 2024
Merged

chore: Upgrade MUI and SDS - SCE-3 SCE-2 #1075

merged 7 commits into from
Aug 20, 2024

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Aug 16, 2024 •
edited by github-actions bot
Loading

MUI Upgrade
SDS Upgrade

Changes:

  • SDS ~20 latest
  • MUI ~5 latest
  • Updated imports
  • Revised props and types where needed
  • Revised implementation (info buttons) where needed
  • Updated theme
  • Updated snapshots

rdev -> HERE

@kaloster kaloster changed the title chore: Upgrade MUI and SDS - SCE-3 chore: Upgrade MUI and SDS - SCE-3 SCE-4 Aug 16, 2024
@kaloster kaloster changed the title chore: Upgrade MUI and SDS - SCE-3 SCE-4 chore: Upgrade MUI and SDS - SCE-3 SCE-2 Aug 16, 2024
@kaloster kaloster requested a review from tihuan August 16, 2024 16:56
@kaloster kaloster added the stack label Aug 16, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.57%. Comparing base (0d204de) to head (1b6edca).
Report is 118 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
+ Coverage   77.47%   77.57%   +0.09%     
==========================================
  Files          88       92       +4     
  Lines        6856     7144     +288     
==========================================
+ Hits         5312     5542     +230     
- Misses       1544     1602      +58
Flag Coverage Δ
frontend 77.57% <ø> (+0.09%) ⬆️
javascript 77.57% <ø> (+0.09%) ⬆️
smokeTest ?
unitTest 77.57% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tihuan
tihuan reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some small discussion items 😄 Thank you!

client/src/components/BottomBanner/index.tsx Outdated Show resolved Hide resolved
client/package.json
Comment on lines +60 to +67
"@czi-sds/components": "^20.7.0",
"@emotion/css": "^11.13.0",
"@emotion/react": "^11.13.0",
"@emotion/styled": "^11.13.0",
"@mui/base": "^5.0.0-beta.40",
"@mui/icons-material": "^5.16.7",
"@mui/lab": "^5.0.0-alpha.173",
"@mui/material": "^5.16.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impressive amount of upgrades 👏 🏆 🫡

client/src/components/NavBar/components/NavDivider/style.ts Show resolved Hide resolved
client/src/components/NavBar/style.ts Show resolved Hide resolved
client/src/components/categorical/value/index.tsx Show resolved Hide resolved
client/src/components/embedding/components/Opacities/components/Opacity/index.tsx Outdated Show resolved Hide resolved
client/src/components/embedding/components/Opacities/components/Opacity/index.tsx Outdated Show resolved Hide resolved
client/src/components/geneExpression/gene/index.tsx Outdated Show resolved Hide resolved
client/src/components/geneExpression/infoPanel/common/style.ts Outdated Show resolved Hide resolved
client/src/components/theme.ts Outdated Show resolved Hide resolved
@kaloster kaloster force-pushed the kaloster/upgrade-material branch 2 times, most recently from d1f84ab to fb811c6 Compare August 19, 2024 20:39
@kaloster kaloster requested a review from tihuan August 19, 2024 21:02
@kaloster kaloster force-pushed the kaloster/upgrade-material branch from cd3a68b to da26654 Compare August 20, 2024 14:07
@kaloster kaloster force-pushed the kaloster/upgrade-material branch from 8992e23 to 0d5a80b Compare August 20, 2024 14:45
tihuan
tihuan approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Just one last comment otherwise super LGTMMMM 🕺 ✨ 🪩

client/src/components/BottomBanner/index.tsx Outdated Show resolved Hide resolved
client/src/components/geneExpression/gene/index.tsx Show resolved Hide resolved
@kaloster kaloster force-pushed the kaloster/upgrade-material branch from 63013e6 to de849f4 Compare August 20, 2024 21:50
@kaloster kaloster enabled auto-merge (squash) August 20, 2024 22:00
@kaloster kaloster merged commit 270653c into main Aug 20, 2024
20 of 21 checks passed
@kaloster kaloster deleted the kaloster/upgrade-material branch August 20, 2024 22:27
@czi-github-helper czi-github-helper bot mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan tihuan approved these changes

Assignees
No one assigned
Labels
stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaloster @tihuan