chore: Python 3.12 (SCE-16) #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaloster
commented
Sep 11, 2024
•
kaloster
commented
- Updated Python version for GHA workflow
- Updated flatbuffers to 2.0.7
- Updated to Scipy 1.14.1
- Updated unit tests and related code
kaloster
commented
Sep 11, 2024
| @@ -51,7 +51,11 @@ def test_tdb_bug(self): | |||
| ) | |||
| dat = data.summarize_var("mean", filt, 0) | |||
| summary = decode_fbs.decode_matrix_FBS(dat) | |||
| self.assertDictContainsSubset({"n_rows": 2638, "n_cols": 1, "row_idx": None}, summary) | |||
There was a problem hiding this comment.
assertDictContainsSubset is deprecated
kaloster
commented
Sep 11, 2024
| @@ -72,7 +72,7 @@ def encode_matrix_fbs(matrix, row_idx=None, col_idx=None, num_bins=None): | |||
| raise ValueError("FBS Matrix must be 2D") | |||
|
|
|||
| if sparse.issparse(matrix): | |||
| matrix = matrix.A | |||
There was a problem hiding this comment.
AttributeError: 'csc_matrix' object has no attribute 'A'
kaloster
force-pushed
the
kaloster/python-312
branch
from
5c230d8 to
2c1e7af
Compare
kaloster
commented
Sep 11, 2024
| @@ -340,7 +340,9 @@ def _un_byteshuffle(buf: Union[bytes, bytearray, memoryview], dtype) -> np.ndarr | |||
|
|
|||
|
|
|||
| def _delta(arr: np.ndarray) -> np.ndarray: | |||
| return np.diff(arr, prepend=arr.dtype.type(0)) | |||
There was a problem hiding this comment.
before this change tests such as def test_roundtrip() would fail for precision 0.999
atarashansky
requested changes
Sep 11, 2024
atarashansky
approved these changes
Sep 11, 2024
kaloster
force-pushed
the
kaloster/python-312
branch
from
e2946ed to
5ec059b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.