Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add aliases and shared folders for renaming #1107

Merged
merged 13 commits into from
Sep 18, 2024

Conversation

rainandbare
Copy link
Contributor

@rainandbare rainandbare commented Sep 18, 2024

This is the beginning of the changes for the Fractal File Structure

In this pr we:

  • Add a common/components folder for high level shared components
  • Add and use aliases for commonly used high level files in order to avoid long file paths as our structure becomes more nested (ie ../../../../../../../../)
  • Make aliases compatible with ESLint and Typescript
  • Move BottomBanner and BrushableHistogram into new locations

@rainandbare rainandbare marked this pull request as ready for review September 18, 2024 16:48
@rainandbare rainandbare changed the title chore: Add Aliases chore: Add aliases and shared folders for renaming Sep 18, 2024
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so clean and easy to read!! Legit tears in my eyes 🥹 ✨

Thank you so much for doing this 🤩 !!

Should we add this to create-sds-app too as a separate ticket? 🚀🚀🚀

@rainandbare
Copy link
Contributor Author

Looks so clean and easy to read!! Legit tears in my eyes 🥹 ✨

Thank you so much for doing this 🤩 !!

Should we add this to create-sds-app too as a separate ticket? 🚀🚀🚀

Yay! Let's do it! I can get to it early next week!

@rainandbare rainandbare merged commit e15a2a4 into main Sep 18, 2024
29 checks passed
@rainandbare rainandbare deleted the rainandbare/add-aliases branch September 18, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants