chore: Rename Left Sidebar #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingle-cell-explorer into rainandbare/leftSidebar
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
+ Coverage 77.47% 77.60% +0.12%
==========================================
Files 88 92 +4
Lines 6856 7162 +306
==========================================
+ Hits 5312 5558 +246
- Misses 1544 1604 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ingle-cell-explorer into rainandbare/leftSidebar
rainandbare
commented
Sep 19, 2024
| @@ -5,7 +5,7 @@ import React from "react"; | |||
| /* App dependencies */ | |||
| import Controls from "common/components/Controls/Controls"; | |||
| import Layout from "./layout"; | |||
| import LeftSidebarSkeleton from "../leftSidebar/leftSidebarSkeleton"; | |||
| import LeftSidebarSkeleton from "../LeftSidebar/LeftSidebarSkeleton"; | |||
There was a problem hiding this comment.
I am going to leave LeftSidebarSkeleton where it is for now cause I don't want to conflict with whatever choices you made about RightSidebarSkeleton.
…ingle-cell-explorer into rainandbare/leftSidebar
rainandbare
added a commit
that referenced
this pull request
Sep 20, 2024
Co-authored-by: rainandbare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming LeftSidebar 👍