feat: scale bar for zoom (SCE-26, SCE-25, SCE-27) #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
=======================================
Coverage 77.60% 77.60%
=======================================
Files 92 92
Lines 7162 7162
=======================================
Hits 5558 5558
Misses 1604 1604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kaloster
force-pushed
the
kaloster/osd-scalebar
branch
2 times, most recently
from
a8a79e5 to
d7cb0a9
Compare
kaloster
force-pushed
the
kaloster/osd-scalebar
branch
from
1a986c5 to
8eee3fa
Compare
kaloster
force-pushed
the
kaloster/osd-scalebar
branch
3 times, most recently
from
bb6dafe to
0e72325
Compare
kaloster
changed the title
kaloster
force-pushed
the
kaloster/osd-scalebar
branch
2 times, most recently
from
6f47670 to
a12442b
Compare
kaloster
commented
Oct 7, 2024
| @@ -91,7 +91,7 @@ const Controls = ( | |||
| loading: false, | |||
| }, | |||
| imageOpacity: isTest ? 0 : 100, | |||
| dotOpacity: 50, | |||
| dotOpacity: 100, | |||
There was a problem hiding this comment.
As per Harley - instead of setting default opacity, update the default color to dark gray for spatial to work with mix blend mode effect
kaloster
changed the title
kaloster
force-pushed
the
kaloster/osd-scalebar
branch
from
f1c318c to
f265734
Compare
|
LGTM thank you for helping clean up! ✨ |
kaloster
force-pushed
the
kaloster/osd-scalebar
branch
from
bf53664 to
f9dbb3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://caring-feline.dev-sc.dev.czi.team/d/super-cool-spatial.cxg/
https://caring-feline.dev-sc.dev.czi.team/d/pbmc3k.cxg/
fullres.mov