Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataset-metadata private collections call #127

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Oct 7, 2021

Reviewers

Functional:
@MDunitz @tihuan

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #127 (1e4653a) into main (56d24af) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1e4653a differs from pull request most recent head c31e5ea. Consider uploading reports for the commit c31e5ea to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         126      126           
  Lines       10106    10106           
=======================================
  Hits         7260     7260           
  Misses       2846     2846           
Flag Coverage Δ
frontend 71.83% <100.00%> (ø)
javascript 71.83% <100.00%> (ø)
smokeTest ?
unitTest 71.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/data_common/dataset_metadata.py 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d24af...c31e5ea. Read the comment docs.

@ebezzi ebezzi enabled auto-merge (squash) October 7, 2021 22:52
@ebezzi ebezzi merged commit 79e4424 into main Oct 7, 2021
Copy link
Contributor

@MDunitz MDunitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebezzi ebezzi deleted the ebezzi/fix-dataset-metadata-for-private-collections branch October 7, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants