-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: collection_url prefix in dataset-metadata #140
fix: collection_url prefix in dataset-metadata #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Emanuele, LGTM!
Would it be possible to add a test for something like that so we don't accidentally regress in the future? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@maniarathi done |
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 71.83% 71.84%
=======================================
Files 126 126
Lines 10106 10108 +2
=======================================
+ Hits 7260 7262 +2
Misses 2846 2846
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thank you! |
Reviewers
Functional:
@MDunitz @MillenniumFalconMechanic @tihuan
Ticket #1539
Changes
/private
as the suffix in thecollection_url
. Note that the suffix for the endpoint which is called internally needs to be different.