Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collection_url prefix in dataset-metadata #140

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Oct 12, 2021

Reviewers

Functional:
@MDunitz @MillenniumFalconMechanic @tihuan

Ticket #1539


Changes

  • Fix the endpoint to return /private as the suffix in the collection_url. Note that the suffix for the endpoint which is called internally needs to be different.

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 !!

Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emanuele, LGTM!

@maniarathi
Copy link
Contributor

Would it be possible to add a test for something like that so we don't accidentally regress in the future?

Copy link
Contributor

@MDunitz MDunitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebezzi
Copy link
Member Author

ebezzi commented Oct 12, 2021

@maniarathi done

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #140 (0d59618) into main (235bacf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   71.83%   71.84%           
=======================================
  Files         126      126           
  Lines       10106    10108    +2     
=======================================
+ Hits         7260     7262    +2     
  Misses       2846     2846           
Flag Coverage Δ
frontend 71.84% <100.00%> (+<0.01%) ⬆️
javascript 71.84% <100.00%> (+<0.01%) ⬆️
smokeTest ?
unitTest 71.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/data_common/dataset_metadata.py 91.78% <100.00%> (+0.11%) ⬆️
data_common/dataset_metadata.py 91.78% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235bacf...0d59618. Read the comment docs.

@maniarathi
Copy link
Contributor

Thank you!

@ebezzi ebezzi merged commit 9558db3 into main Oct 13, 2021
@ebezzi ebezzi deleted the ebezzi/1539-fix-collection-url-in-dataset-metadata branch October 13, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants