fix: 156 obsolete browsers #159
Conversation
tihuan
force-pushed
the
thuang-fix-obsolete-browsers
branch
2 times, most recently
from
a75b3b4 to
a6e95ad
Compare
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 71.84% 71.85% +0.01%
==========================================
Files 126 126
Lines 10108 10106 -2
==========================================
Hits 7262 7262
+ Misses 2846 2844 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| <script> | ||
| /** Reflect ANY changes to this script in the script hash in `server/eb/app.py` **/ | ||
| var root = document.getElementById("root"); | ||
| root.remove(); | ||
| var portals = document.getElementsByClassName("bp3-portal"); | ||
| for (var i = 0; i < portals.length; i += 1) { | ||
| portals[i].remove(); | ||
| } | ||
| </script> |
There was a problem hiding this comment.
We're going to need to update CSP
There was a problem hiding this comment.
Ah thank you! Yeah we can remove the associated hash now! I'll add it as a TODO in the PR and ticket descriptions 👍
There was a problem hiding this comment.
OH! It's just in the BE code not in Infra repo lol Updated! Thank you!
tihuan
force-pushed
the
thuang-fix-obsolete-browsers
branch
from
a6e95ad to
078e2de
Compare
|
@seve PTAL again thank you 🙏 |
| <script | ||
| async | ||
| src="static/obsoleteBrowsers.js" | ||
| id="obsolete-browsers" | ||
| data-template="<%= OBSOLETE_TEMPLATE %>" | ||
| data-regex="<%= OBSOLETE_REGEX %>" | ||
| ></script> |
There was a problem hiding this comment.
Is this going to need to be reflected in CSP?
There was a problem hiding this comment.
Great question! Since the script will be served from the same domain as the HTML page, script-src "'self'" should cover it. Only inline scripts need hashes 👍
| @@ -0,0 +1,22 @@ | |||
| /* eslint-disable @blueprintjs/classes-constants -- do not import files */ | |||
There was a problem hiding this comment.
Maybe this too will need to be included in CSP?
There was a problem hiding this comment.
Please see comment above!
Reviewers
Functional:
@seve
Readability:
@dimple-jethani
Changes
This PR replaces
obsolete-webpack-pluginand usesbrowserslist-useragent-regexpto generate a REGEX to test thenavigator.userAgentinsteadThe strategy is:
browserslist-useragent-regexpto generate REGEX based onbrowserslistand output a fileconfiguration/webpack/SUPPORTED_BROWSERS_REGEX.jsconfiguration/webpack/webpack.config.shared.jsimports the REGEX and obsolete html template and inject them into bothindex.htmlandindex_template.htmlon the designated script tag.configuration/webpack/webpack.config.shared.jsalso copies the static fileconfiguration/webpack/obsoleteBrowsers.jsinto the/build/static/directory, so the servers know how to handle the request for the fileindex.htmlandindex_template.htmlthen loads the script file script tag in step 2 viasrc="obsoleteBrowsers.js". NOTE: we continue to use relative path here instead of absolute path, so the request will still be prefixed with data root path (the namespace needed for CloudFront)obsoleteBrowsers.jsis now downloaded asynchronously and parse REGEX and HTML template from its script tag attributes and test the browser and render the obsolete HTML as neededSafari:
Chrome:
🚨🚨🚨 TODO 🚨🚨🚨
1. Still need to remove associated script hash inFalse alarmsingle-cell-infrarepo