fix: e2e base url #179
Merged
fix: e2e base url #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const pageUrl = [appUrlBase, defaultBaseUrl, DATASET].join("/"); | ||
| const pageUrl = appUrlBase.includes("localhost") | ||
| ? [appUrlBase, defaultBaseUrl, DATASET].join("/") | ||
| : appUrlBase; |
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 126 126
Lines 10098 10098
=======================================
Hits 7242 7242
Misses 2856 2856
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Bento007
added a commit
that referenced
this pull request
Nov 4, 2021
* main: Delete schema_guide.md (#131) chore(deps): bump urllib3 from 1.25.9 to 1.26.5 in /hosted (#186) chore(deps): bump jinja2 from 2.11.2 to 2.11.3 in /hosted (#185) fix: dont cache dataset metadata (#177) explorer rdev (#144) Updated load indicator to match skeleton. (#139) (#171) Always show scrollbar on dataset menu if scrollable. (#138) (#173) fix: e2e base url (#179) # Conflicts: # hosted/requirements.txt # server/app/app.py # server/tests/unit/common/apis/test_api_v2.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
Readability:
Changes