fix: remove trailing slash from s3_uri

[Bento007]

Reviewers

Functional: @atolopko-czi

Readability: @seve

---

Remove trailing slash from the s3_uri that is used in the /s3_uri/<s3_uri>/api/v0.3 requests, to ensure that all requests are properly utilizing the CloudFront cache. This woull change this:

/cellxgene/s3_uri/s3%253A%252F%252Fhosted-cellxgene-dev%252Fpbmc3k.cxg%252F/api/v0.3/genesets

to this

/cellxgene/s3_uri/s3%253A%252F%252Fhosted-cellxgene-dev%252Fpbmc3k.cxg/api/v0.3/genesets

Changes

• remove the trailing slash from S3_URIs before returning in GET */s3_uri

[codecov]

Codecov Report

Merging #198 (8bb2304) into main (1aed6aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   70.39%   70.40%           
=======================================
  Files         132      132           
  Lines       10020    10022    +2     
=======================================
+ Hits         7054     7056    +2     
  Misses       2966     2966           

Flag	Coverage Δ
frontend	70.40% <100.00%> (+<0.01%)	⬆️
javascript	70.40% <100.00%> (+<0.01%)	⬆️
smokeTest	?
unitTest	70.40% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/app/api/util.py	100.00% <100.00%> (ø)
app/api/util.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aed6aa...8bb2304. Read the comment docs.

[atolopko-czi]

LGTM. Could be worth adding a test to help protect any inadvertent removal of this no-slash requirement. Similarly adding a comment here to explain the purpose would be useful.

[atolopko-czi]

Beyond the scope of this PR, it seems worth "fixing" this in data portal as well by having an explicit, validated format there (i.e. no trailing slash). Similarly for explorer URLs, since there exists a hack to query for explorer URLs that may or may not have a trailing slash. I can create stories for this, but seeking input.

[Bento007]

It seems like a low priority, but something worth doing eventually.