fix: verify caching headers for dataset-metadata #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 70.42% 70.42%
=======================================
Files 132 132
Lines 10028 10028
=======================================
Hits 7062 7062
Misses 2966 2966
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
atolopko-czi
requested changes
Dec 9, 2021
| def verify_response(self, result): | ||
| self.assertEqual(result.status_code, HTTPStatus.OK) | ||
| self.assertEqual(result.headers["Content-Type"], "application/json") | ||
| self.assertTrue(result.cache_control.public) |
There was a problem hiding this comment.
out of scope for this test-focused PR, but if we're not allowing caching I don't think public is useful; if you agree, can you make a cool down story to remove it?
There was a problem hiding this comment.
you mean remove public from the cache headers in dataset-metadata?
atolopko-czi
approved these changes
Dec 17, 2021
| url_base = "/".join( | ||
| [self.api_url_base, "cellxgene", "s3_uri", quote(quote(body, safe=""), safe=""), "api/v0.3"] | ||
| ) | ||
| endpoints = ["config", "schema", "colors", "genesets", "layout/obs", "annotations/obs", "annotations/var"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional: @atolopko-czi
Readability:
related to #200
Changes