feat: add publisher_metadata to the dataset metadata endpoint #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebezzi
commented
Feb 4, 2022
| @@ -138,6 +138,9 @@ def get_dataset_and_collection_metadata(dataset_root: str, dataset_id: str, app_ | |||
| "collection_datasets": res["datasets"], | |||
| } | |||
|
|
|||
| if res.get("publisher_metadata"): | |||
There was a problem hiding this comment.
.get to make sure that we only add this if it exists and is not null.
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 75.14% 75.16% +0.01%
==========================================
Files 84 84
Lines 6132 6136 +4
==========================================
+ Hits 4608 4612 +4
Misses 1524 1524
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
metakuni
approved these changes
Feb 7, 2022
ebezzi
deleted the
ebezzi/add-publisher-metadata-to-dataset-metadata-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
@atolopko-czi @MDunitz
Readability:
Changes
publisher_metadatafield to the dataset metadata endpoint call.