Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use gunicorn for ecs #250

Merged
merged 3 commits into from
May 6, 2022
Merged

chore: use gunicorn for ecs #250

merged 3 commits into from
May 6, 2022

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented May 6, 2022

Reviewers

Functional:
@atolopko-czi

Readability:


Changes

  • add
  • remove
  • modify

@ebezzi ebezzi requested a review from atolopko-czi May 6, 2022 14:15
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #250 (2aed384) into main (0961cc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   76.47%   76.47%           
=======================================
  Files          92       92           
  Lines        6758     6758           
=======================================
  Hits         5168     5168           
  Misses       1590     1590           
Flag Coverage Δ
frontend 76.47% <ø> (ø)
javascript 76.47% <ø> (ø)
smokeTest ?
unitTest 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0961cc9...2aed384. Read the comment docs.

Copy link
Contributor

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the gunicornification was straight-forward in the end! 👏

@ebezzi ebezzi merged commit 8544eb5 into main May 6, 2022
@ebezzi ebezzi deleted the ebezzi/use-gunicorn-for-ecs branch May 6, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants