Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up development guidelines. #253

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

maniarathi
Copy link
Contributor

Reviewers

Functional: @ebezzi

Readability: N/A


Changes

Additions

  • Added flake8 as a dependency in the dev requirements. Without this, the linter commands were failing.

Modifications

  • Modified the top-level Makefile so that sections of commands were clearer.
  • Moved information around in the developer guidelines to make the instructions more clear. Also removed outdated commands and deprecated information about annotations.

@maniarathi maniarathi requested a review from ebezzi May 7, 2022 02:51
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #253 (614dac4) into main (981cb3e) will not change coverage.
The diff coverage is n/a.

❗ Current head 614dac4 differs from pull request most recent head 425c2e9. Consider uploading reports for the commit 425c2e9 to get more accurate results

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   76.47%   76.47%           
=======================================
  Files          92       92           
  Lines        6758     6758           
=======================================
  Hits         5168     5168           
  Misses       1590     1590           
Flag Coverage Δ
frontend 76.47% <ø> (ø)
javascript 76.47% <ø> (ø)
smokeTest ?
unitTest 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981cb3e...425c2e9. Read the comment docs.

Copy link
Contributor

@MDunitz MDunitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maniarathi maniarathi enabled auto-merge (squash) May 10, 2022 02:09
@maniarathi maniarathi merged commit baeb431 into main May 10, 2022
@maniarathi maniarathi deleted the maniarathi/dev_docs_fixes branch May 10, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants