feat: gene info cards #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 76.16% 76.28% +0.11%
==========================================
Files 90 90
Lines 6670 6712 +42
==========================================
+ Hits 5080 5120 +40
- Misses 1590 1592 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
…erberg/single-cell-explorer into sienacizdziel/gene-info
* adding in backend changes * unit tests and status codes * requested change * requested change Co-authored-by: Siena Cizdziel <[email protected]>
* feature id checks, reverting global rightsidebarwidth change, passing smoke tests * chore: gene info icon and minor design changes (#320) * icon changes * requested design changes Co-authored-by: Siena Cizdziel <[email protected]> Co-authored-by: Siena Cizdziel <[email protected]>
* remove error checking for no feature id column * functionality for datasets that don't have feature ids * lint * removing style changes * hook up new api endpoint * add gene param Co-authored-by: Siena Cizdziel <[email protected]>
seve
suggested changes
Jul 25, 2022
| // if feature id column is available in var | ||
| if (annoMatrix.getMatrixColumns("var").includes(geneIdCol)) { | ||
| dfIds = await annoMatrix.fetch("var", geneIdCol); | ||
| console.log("id, success"); |
There was a problem hiding this comment.
I removed the console.log, but the rest I think is still important for datasets that contain feature_id columns
| console.error("Could not find feature IDs."); | ||
| } | ||
|
|
||
| setStatus("name, success"); |
There was a problem hiding this comment.
This code is only for datasets that already have the "feature_id" column. Otherwise, we'll call the API with only gene name, since we don't have gene IDs built into the dataset (more of the code is implemented in the other PR that just recently got merged to this one)
…erberg/single-cell-explorer into sienacizdziel/gene-info
…erberg/single-cell-explorer into sienacizdziel/gene-info
seve
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
frontend: @seve
backend in #323 : @MDunitz
Readability:
Depends on PRs:
Changes
Notes for Reviewers
For my intern project: gene info cards. This feature allows users to search gene information (e.g. gene description, summary, synonyms, etc) about a gene in question by clicking on an info circle next to a gene name. On info button click, a pop-up similar to the scatterplot feature appears. This works for genes in both quick gene and genesets.