Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable deployment on rdev #299

Merged
merged 21 commits into from
Jul 8, 2022
Merged

fix: enable deployment on rdev #299

merged 21 commits into from
Jul 8, 2022

Conversation

roaga
Copy link
Contributor

@roaga roaga commented Jun 27, 2022

Reviewers

Functional:
@ebezzi

Readability:
@Bento007


Changes

  • modify config files to allow Explorer to be deployed on rdev.
  • modify Docker-related files to take advantage of caching and trim extra files.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #299 (f614276) into main (aa4beab) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   76.13%   76.16%   +0.02%     
==========================================
  Files          90       90              
  Lines        6662     6670       +8     
==========================================
+ Hits         5072     5080       +8     
  Misses       1590     1590              
Flag Coverage Δ
frontend 76.16% <100.00%> (+0.02%) ⬆️
javascript 76.16% <100.00%> (+0.02%) ⬆️
smokeTest ?
unitTest 76.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/common/utils/data_locator.py 38.63% <ø> (ø)
server/app/app.py 60.00% <100.00%> (+1.26%) ⬆️
common/utils/data_locator.py 38.63% <0.00%> (ø)
app/app.py 60.00% <0.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4beab...f614276. Read the comment docs.

hosted/Dockerfile Outdated Show resolved Hide resolved
hosted/Dockerfile Outdated Show resolved Hide resolved
hosted/Dockerfile Outdated Show resolved Hide resolved
@roaga roaga marked this pull request as ready for review July 8, 2022 16:41
@roaga roaga enabled auto-merge (squash) July 8, 2022 20:12
@roaga roaga merged commit 10fe915 into main Jul 8, 2022
@roaga roaga deleted the roaga/happy-fix branch July 8, 2022 20:19
seve added a commit that referenced this pull request Jul 19, 2022
* chore: runtime config (#310)

* chore: runtime config

* reqs

* add config.yaml to the dockerfile

* Remove print

* Remove comments

* Missing ADD argument

* fix some tf issues

* chore: add missing config.yaml file (#312)

* chore: increase staging container count to 2 (#313)

* fix: enable deployment on rdev (#299)

* Add symlink

* Update env config

* Update health check path

* Add temporary workarounds and warnings

* Workaround missing s3 bucket

* add request logging

* Repair explorer rdev

* Remove unused config file

* Cleanup

* Clean up

* Lint

* Reorder dockerfile to take advantage of caching

* Remove unnecessary installations

* Ignore node_modules in docker image to save space

* Fix cache-from tag in Docker

* fix conflicts

* Reorder Dockerfile for caching

Co-authored-by: Trent Smith <[email protected]>
Co-authored-by: Emanuele Bezzi <[email protected]>

* Combine run statements into one layer (#314)

* chore: add happy locking (#318)

Co-authored-by: Emanuele Bezzi <[email protected]>
Co-authored-by: Rohan Agarwal <[email protected]>
Co-authored-by: Trent Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants