Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regen package-lock.json file to solve dependency issue in dev #301

Merged
merged 7 commits into from
Jun 28, 2022
Merged

fix: regen package-lock.json file to solve dependency issue in dev #301

merged 7 commits into from
Jun 28, 2022

Conversation

sienacizdziel
Copy link
Contributor

Reviewers

Functional:

Readability:

Changes

  • add
  • remove
  • modify

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #301 (9386814) into main (8720b99) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files          90       90           
  Lines        6660     6660           
=======================================
  Hits         5070     5070           
  Misses       1590     1590
Flag Coverage Δ
frontend 76.12% <ø> (ø)
javascript 76.12% <ø> (ø)
smokeTest ?
unitTest 76.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8720b99...9386814. Read the comment docs.

@sienacizdziel sienacizdziel requested a review from seve June 28, 2022 01:27
@sienacizdziel sienacizdziel changed the title Sienacizdziel/sds fix fix: regen package-lock.json file to solve dependency issue in dev Jun 28, 2022
@sienacizdziel sienacizdziel merged commit 4d58c23 into main Jun 28, 2022
@sienacizdziel sienacizdziel deleted the sienacizdziel/sds-fix branch June 28, 2022 16:45
sienacizdziel added a commit that referenced this pull request Jun 28, 2022
@sienacizdziel
Revert "fix: regen package-lock.json file to solve dependency issue i…
34cf401 
…n dev (#301)"

This reverts commit 4d58c23.
@sienacizdziel sienacizdziel mentioned this pull request Jun 28, 2022
Closed
atolopko-czi added a commit that referenced this pull request Jun 28, 2022
@atolopko-czi
Revert "fix: regen package-lock.json file to solve dependency issue i…
a84bcfb 
…n dev (#301)"

This reverts commit 4d58c23.
atolopko-czi added a commit that referenced this pull request Jun 28, 2022
@atolopko-czi
revert prs 300 301 (#303)
d8c131d 
* Revert "fix: regen package-lock.json file to solve dependency issue in dev (#301)"

This reverts commit 4d58c23.

* Revert "chore: migrate sds to explorer (#300)"

This reverts commit 8720b99.
@czi-github-helper czi-github-helper bot mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seve seve seve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sienacizdziel @seve