chore: increase staging container count to 2 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 76.13% 76.13%
=======================================
Files 90 90
Lines 6662 6662
=======================================
Hits 5072 5072
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
seve
approved these changes
Jul 8, 2022
MDunitz
approved these changes
Jul 8, 2022
I would either keep dev to 1 or decrease the memory, to save resources. |
seve
added a commit
that referenced
this pull request
Jul 19, 2022
* chore: runtime config (#310) * chore: runtime config * reqs * add config.yaml to the dockerfile * Remove print * Remove comments * Missing ADD argument * fix some tf issues * chore: add missing config.yaml file (#312) * chore: increase staging container count to 2 (#313) * fix: enable deployment on rdev (#299) * Add symlink * Update env config * Update health check path * Add temporary workarounds and warnings * Workaround missing s3 bucket * add request logging * Repair explorer rdev * Remove unused config file * Cleanup * Clean up * Lint * Reorder dockerfile to take advantage of caching * Remove unnecessary installations * Ignore node_modules in docker image to save space * Fix cache-from tag in Docker * fix conflicts * Reorder Dockerfile for caching Co-authored-by: Trent Smith <[email protected]> Co-authored-by: Emanuele Bezzi <[email protected]> * Combine run statements into one layer (#314) * chore: add happy locking (#318) Co-authored-by: Emanuele Bezzi <[email protected]> Co-authored-by: Rohan Agarwal <[email protected]> Co-authored-by: Trent Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
Readability:
Changes