fix: make push rdev use happy go client #336
Conversation
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 90 90
Lines 6670 6670
=======================================
Hits 5080 5080
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
approving with 2 minor suggestions to consider. @ebezzi might be the better reviewer, since I believe he did the work on moving portal to go happy client (in case I'm missing a reason why we shouldn't be doing this.)
| - name: Build component | ||
| shell: bash | ||
| run: | | ||
| pip install -r .happy/requirements.txt |
There was a problem hiding this comment.
should also rm this reqs.txt file
| DOCKER_TAG=${GITHUB_REF#refs/heads/} | ||
| DOCKER_TAG=${DOCKER_TAG#refs/tags/} | ||
| # replace `/` with `_` |
There was a problem hiding this comment.
keeping the comment may save someone some head scratching :)
This reverts commit 1b10f5e.
Switches the workflow to use the go client.
This successful run uses the yaml copied into this PR: https://github.com/chanzuckerberg/single-cell-explorer/actions/runs/2719326953
Reviewers
Functional:
@atolopko-czi