chore: type centroid util

[seve]

Type the centroid util and call sites as well as needed imports.

Note:

I did some retyping of the CategeoricalColumnSchema to make the categories field required on columns with type `categorical'. We'll have to do some tuning (#35) to reduce casting in favor of type guarding.

I also had to untype nextSharedState (it was typing as RootState) as I believe it opens up a self reference . This should be fixed in #9 cc: @colinmegill

[codecov]

Codecov Report

Merging #36 (7239682) into main (32d5f08) will not change coverage.
The diff coverage is n/a.

❗ Current head 7239682 differs from pull request most recent head 700517d. Consider uploading reports for the commit 700517d to get more accurate results

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   71.70%   71.70%           
=======================================
  Files         126      126           
  Lines        9988     9988           
=======================================
  Hits         7162     7162           
  Misses       2826     2826           

Flag	Coverage Δ
frontend	71.70% <ø> (ø)
javascript	71.70% <ø> (ø)
smokeTest	?
unitTest	71.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d5f08...700517d. Read the comment docs.

[tihuan]

LGTM!! Thanks for updating the types, @seve 🙏 Just one question! Thank you!

[bkmartinjr]

Overall looks good, with one caveat: the centrol helpers assume all labels are strings, which is incorrect AFAIK. We can have datasets with non-string categoricals (numbers, bools, etc).

[bkmartinjr]

Optional: given the confusion around the type of an obsAnnnotation, you may want to add tests which exercise the other label types (eg, number or boolean or blended)

[bkmartinjr]

@seve - you re-requested a review, but I don't see any changes to util/centroid.ts -- it still assumes that all obs categories contain only strings, as far as I can tell...

[bkmartinjr]

LGTM.

You might consider additional test coverage as noted inline.