chore: updating logo #389
Merged
chore: updating logo #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
|
So since the top left logo icon is just an SVG element of styled rectangles, I just changed the colors to match the rebrand logo. Let me know your thoughts: Full page: |
seve
approved these changes
Aug 12, 2022
|
@hthomas-czi can you provide guidance on the right logo to use here? |
|
@ambrosejcarr @hthomas-czi Just wanted to see if I could get an update for what direction we should take for this Currently the Explorer logo icon is just an HTML SVG element of rectangles, styled to resemble the logo. So it doesn't use any image for the logo currently. I made updates to have the new icon match the rebranded logo as close that I can, but need a decision to whether keep using the HTML elements, or use the PNG image for the logo. |
|
@ashin-czi This logo doesn't need to be updated. It will be removed as part of #382. |
Good to know, thank you! Do you know if this is also the case for CellxGene Annotate? I believe that also has the top left icon on the visualize UI. |
seve
approved these changes
Aug 24, 2022
|
Ready for staging |
danieljhegeman
pushed a commit
that referenced
this pull request
Aug 30, 2022
* chore: updating logo (#389) * chore: updating logo * feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384) * added loading spinner to mean colorby and fixed legend async bug * revert prettier * temp fix tsc emit * typed * fix * fixed bugs Co-authored-by: atarashansky <[email protected]> * typed obs crossfilter (#420) Co-authored-by: atarashansky <[email protected]> * typed categorical selection reducer (#417) Co-authored-by: atarashansky <[email protected]> * typed differential reducer (#419) Co-authored-by: atarashansky <[email protected]> * typed annoMatrix reducer (#416) Co-authored-by: atarashansky <[email protected]> * chore: purge autosave from codebase (#425) * chore: typed genesetsUI reducer * fix tsc error * chore: purge autosave * delete nameNewAnnotation * remove unused Co-authored-by: atarashansky <[email protected]> * chore: typed controls reducer (#418) * typed controls reducer * refine scatterplot accessor type to be string or false * address revisions * type level return function Co-authored-by: atarashansky <[email protected]> * typed point dilation (#421) Co-authored-by: atarashansky <[email protected]> * Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428) This reverts commit b265fcf. * typed graph selection reducer (#422) Co-authored-by: atarashansky <[email protected]> * chore: typed cascade reducer (#426) * test * update cascade reducer * add map as possible type for cascade * refactor(cascadeReducer): Quick feedback (#427) * revert changes * Update client/src/reducers/cascade.ts Co-authored-by: Severiano Badajoz <[email protected]> * remove as string * refactor(cascadeReducer): Quick feedback 2 (#430) Co-authored-by: atarashansky <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]> * chore: typed genesetsUI reducer (#423) * chore: typed genesetsUI reducer * fix tsc error Co-authored-by: atarashansky <[email protected]> * chore: typed config reducer (#424) * chore: typed config reducer * restrict error type Co-authored-by: atarashansky <[email protected]> Co-authored-by: ashin-czi <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: Nayib Gloria <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]>
danieljhegeman
pushed a commit
that referenced
this pull request
Sep 1, 2022
* chore: updating logo (#389) * chore: updating logo * feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384) * added loading spinner to mean colorby and fixed legend async bug * revert prettier * temp fix tsc emit * typed * fix * fixed bugs Co-authored-by: atarashansky <[email protected]> * typed obs crossfilter (#420) Co-authored-by: atarashansky <[email protected]> * typed categorical selection reducer (#417) Co-authored-by: atarashansky <[email protected]> * typed differential reducer (#419) Co-authored-by: atarashansky <[email protected]> * typed annoMatrix reducer (#416) Co-authored-by: atarashansky <[email protected]> * chore: purge autosave from codebase (#425) * chore: typed genesetsUI reducer * fix tsc error * chore: purge autosave * delete nameNewAnnotation * remove unused Co-authored-by: atarashansky <[email protected]> * chore: typed controls reducer (#418) * typed controls reducer * refine scatterplot accessor type to be string or false * address revisions * type level return function Co-authored-by: atarashansky <[email protected]> * typed point dilation (#421) Co-authored-by: atarashansky <[email protected]> * Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428) This reverts commit b265fcf. * typed graph selection reducer (#422) Co-authored-by: atarashansky <[email protected]> * chore: typed cascade reducer (#426) * test * update cascade reducer * add map as possible type for cascade * refactor(cascadeReducer): Quick feedback (#427) * revert changes * Update client/src/reducers/cascade.ts Co-authored-by: Severiano Badajoz <[email protected]> * remove as string * refactor(cascadeReducer): Quick feedback 2 (#430) Co-authored-by: atarashansky <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]> * chore: typed genesetsUI reducer (#423) * chore: typed genesetsUI reducer * fix tsc error Co-authored-by: atarashansky <[email protected]> * chore: typed config reducer (#424) * chore: typed config reducer * restrict error type Co-authored-by: atarashansky <[email protected]> Co-authored-by: ashin-czi <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: Nayib Gloria <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]> Co-authored-by: ashin-czi <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: Nayib Gloria <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#385
Reviewers
Functional: @seve @ambrosejcarr
Readability: @seve @ambrosejcarr
Changes