Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataset metadata response parsing #43

Merged
merged 4 commits into from
Sep 8, 2021
Merged

fix: dataset metadata response parsing #43

merged 4 commits into from
Sep 8, 2021

Conversation

MDunitz
Copy link
Contributor

@MDunitz MDunitz commented Sep 8, 2021

Reviewers

Functional:


Changes

  • modify dataset metadata retrieval code to properly handle response body

@MDunitz MDunitz requested a review from ebezzi September 8, 2021 02:52
@MDunitz MDunitz changed the title Dunitz/testing fix: dataset metadata response parsing Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #43 (7f1c599) into main (2ba9729) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   69.22%   69.22%           
=======================================
  Files         100      100           
  Lines        9026     9026           
=======================================
  Hits         6248     6248           
  Misses       2778     2778           
Flag Coverage Δ
frontend 69.22% <100.00%> (ø)
javascript 69.22% <100.00%> (ø)
smokeTest ?
unitTest 69.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/czi_hosted/data_common/dataset_metadata.py 89.79% <100.00%> (ø)
data_common/dataset_metadata.py 89.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba9729...7f1c599. Read the comment docs.

@MDunitz MDunitz merged commit 084dc5c into main Sep 8, 2021
@MDunitz MDunitz deleted the dunitz/testing branch September 8, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants