Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed bug where continuous legend is appearing for categorical color-bys #440

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

atarashansky
Copy link
Contributor

Fixes #439

@atarashansky atarashansky requested a review from tihuan September 12, 2022 20:43
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #440 (36546e3) into main (ece5754) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files         100      100           
  Lines        7756     7756           
=======================================
  Hits         5790     5790           
  Misses       1966     1966           
Flag Coverage Δ
frontend 74.65% <ø> (ø)
javascript 74.65% <ø> (ø)
smokeTest ?
unitTest 74.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@atarashansky atarashansky enabled auto-merge (squash) September 12, 2022 20:51
@atarashansky atarashansky merged commit fc35d0c into main Sep 12, 2022
@atarashansky atarashansky deleted the atar/legend-fix branch September 12, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] coloring by some categoricals spawns a continuous colorbar
2 participants