fix(navbar): WMG link #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tihuan
force-pushed
the
thuang-update-navbar-wmg
branch
from
747eb08 to
b5aebc3
Compare
Codecov Report
@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 100 100
Lines 7800 7800
=======================================
Hits 5852 5852
Misses 1948 1948
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atarashansky
approved these changes
Sep 16, 2022
| @@ -1 +1 @@ | |||
| module.exports = /((CPU[ +]OS|iPhone[ +]OS|CPU[ +]iPhone|CPU IPhone OS)[ +]+(10[_.]3|10[_.]([4-9]|\d{2,})|(1[1-9]|[2-9]\d|\d{3,})[_.]\d+|11[_.]0|11[_.]([1-9]|\d{2,})|11[_.]2|11[_.]([3-9]|\d{2,})|(1[2-9]|[2-9]\d|\d{3,})[_.]\d+|12[_.]0|12[_.]([1-9]|\d{2,})|12[_.]5|12[_.]([6-9]|\d{2,})|(1[3-9]|[2-9]\d|\d{3,})[_.]\d+|13[_.]0|13[_.]([1-9]|\d{2,})|13[_.]7|13[_.]([8-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})[_.]\d+|14[_.]0|14[_.]([1-9]|\d{2,})|14[_.]4|14[_.]([5-9]|\d{2,})|14[_.]8|14[_.](9|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})[_.]\d+|15[_.]0|15[_.]([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})[_.]\d+)(?:[_.]\d+)?)|(CFNetwork\/8.* Darwin\/16\.5\.\d+)|(CFNetwork\/8.* Darwin\/16\.6\.\d+)|(CFNetwork\/8.* Darwin\/16\.7\.\d+)|(CFNetwork\/8.* Darwin\/17\.0\.\d+)|(CFNetwork\/8.* Darwin\/17\.2\.\d+)|(CFNetwork\/8.* Darwin\/17\.3\.\d+)|(CFNetwork\/8.* Darwin\/17\.\d+)|(Edge\/(79(?:\.0)?|79(?:\.([1-9]|\d{2,}))?|([8-9]\d|\d{3,})(?:\.\d+)?|83(?:\.0)?|83(?:\.([1-9]|\d{2,}))?|(8[4-9]|9\d|\d{3,})(?:\.\d+)?))|((Chromium|Chrome)\/(61\.0|61\.([1-9]|\d{2,})|(6[2-9]|[7-9]\d|\d{3,})\.\d+|83\.0|83\.([1-9]|\d{2,})|(8[4-9]|9\d|\d{3,})\.\d+)(?:\.\d+)?)|(Firefox\/(60\.0|60\.([1-9]|\d{2,})|(6[1-9]|[7-9]\d|\d{3,})\.\d+)\.\d+)|(Firefox\/(60\.0|60\.([1-9]|\d{2,})|(6[1-9]|[7-9]\d|\d{3,})\.\d+)(pre|[ab]\d+[a-z]*)?)/; | |||
| module.exports = /((CPU[ +]OS|iPhone[ +]OS|CPU[ +]iPhone|CPU IPhone OS)[ +]+(10[_.]3|10[_.]([4-9]|\d{2,})|(1[1-9]|[2-9]\d|\d{3,})[_.]\d+|11[_.]0|11[_.]([1-9]|\d{2,})|11[_.]2|11[_.]([3-9]|\d{2,})|(1[2-9]|[2-9]\d|\d{3,})[_.]\d+|12[_.]0|12[_.]([1-9]|\d{2,})|12[_.]5|12[_.]([6-9]|\d{2,})|(1[3-9]|[2-9]\d|\d{3,})[_.]\d+|13[_.]0|13[_.]([1-9]|\d{2,})|13[_.]7|13[_.]([8-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})[_.]\d+|14[_.]0|14[_.]([1-9]|\d{2,})|14[_.]4|14[_.]([5-9]|\d{2,})|14[_.]8|14[_.](9|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})[_.]\d+|15[_.]0|15[_.]([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})[_.]\d+|16[_.]0|16[_.]([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})[_.]\d+)(?:[_.]\d+)?)|(CFNetwork\/8.* Darwin\/16\.5\.\d+)|(CFNetwork\/8.* Darwin\/16\.6\.\d+)|(CFNetwork\/8.* Darwin\/16\.7\.\d+)|(CFNetwork\/8.* Darwin\/17\.0\.\d+)|(CFNetwork\/8.* Darwin\/17\.2\.\d+)|(CFNetwork\/8.* Darwin\/17\.3\.\d+)|(CFNetwork\/8.* Darwin\/17\.\d+)|(Edge\/(79(?:\.0)?|79(?:\.([1-9]|\d{2,}))?|([8-9]\d|\d{3,})(?:\.\d+)?|83(?:\.0)?|83(?:\.([1-9]|\d{2,}))?|(8[4-9]|9\d|\d{3,})(?:\.\d+)?))|((Chromium|Chrome)\/(61\.0|61\.([1-9]|\d{2,})|(6[2-9]|[7-9]\d|\d{3,})\.\d+|83\.0|83\.([1-9]|\d{2,})|(8[4-9]|9\d|\d{3,})\.\d+)(?:\.\d+)?)|(Firefox\/(60\.0|60\.([1-9]|\d{2,})|(6[1-9]|[7-9]\d|\d{3,})\.\d+)\.\d+)|(Firefox\/(60\.0|60\.([1-9]|\d{2,})|(6[1-9]|[7-9]\d|\d{3,})\.\d+)(pre|[ab]\d+[a-z]*)?)/; | |||
There was a problem hiding this comment.
This keeps changing for me locally as well and keep needing to omit it from the git commit. Out of curiousity, what is this file and why is it updating?
There was a problem hiding this comment.
Ah sorry for the confusion! Please feel free to add the change in PRs in the future!
This file is constantly updated to match the browser versions we support as listed out in package.json["browserslist"]
We have an npm script create-supported-browsers-regex that's hooked into npm run build. That's why it's updated when we run npm run build 🙆♂️
nayib-jose-gloria
added a commit
that referenced
this pull request
Sep 20, 2022
* Updating explorer to appropriately handle upgraded CXGs (#431) * update explorer to use two X arrays * update for backwards compatibility * bug fix * fix accidental recursion * fix shape return * more fixes to backwards compatibility * black * black * update to use attr(0) for unit tests failing due to anonymous attr name * refactor row array name * make use for dictionary encoded obs array * update query_obs_array * update query_obs_array * fix_typo * black * fix faulty except block * remaster pbmc3k.cxg obs array * remaster * black * black p2 * revert * update docs * revert * update docs * revise not mandatory * add comment * clearer arg * remove param from docstring * version update * update arg usage to colwise * add clause * update tests with sparse data fixture * black * update tests * update tests * combine more tests with subtests Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> * Upgrade Flask and other server python dependencies (#438) * wip * wip * wip * revert push_tests branch change Co-authored-by: Mike Lin <[email protected]> Co-authored-by: atarashansky <[email protected]> * bug fix (#446) Co-authored-by: atarashansky <[email protected]> * Added the data portal navigation bar to explorer (#382) * added unified navbar * clean up * updates * remove Roboto declaration * remove Embedding and Autosave * remove home from dataset selector and move it to the bottom - add dropdown to help * fix lint * fix: SVG import * upgrade node version * add Roboto Condensed * fix: add back code change dropped from resolving merge conflicts * chore: update package-lock.json * fix: ts lint * update test * update test Co-authored-by: atarashansky <[email protected]> Co-authored-by: Timmy Huang <[email protected]> * chore(node): Upgrade to 16 in Dockerfile (#448) * update doc version (#447) Co-authored-by: atarashansky <[email protected]> * fix(navbar): WMG link (#449) * fix edge case where categories dont exist for categoricals (#450) Co-authored-by: atarashansky <[email protected]> * chore: Add server timings to gene expression API routes (#451) * add server timing to dataset query and encode * add server timing to dataset query and encode * remove f strings Co-authored-by: atarashansky <[email protected]> * fix timing (#452) Co-authored-by: atarashansky <[email protected]> * revert mapColumns to default behavior. engineers are now responsible for handling dict encoded arrays in the callback (#454) Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: Mike Lin <[email protected]> Co-authored-by: Mike Lin <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Timmy Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
Readability:
Changes