fix: hide navbar when seamless not enabled #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #482 +/- ##
=======================================
Coverage 74.99% 74.99%
=======================================
Files 99 99
Lines 7815 7815
=======================================
Hits 5861 5861
Misses 1954 1954
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atarashansky
force-pushed
the
atar/hide-navbar
branch
from
92adba9 to
1d2385e
Compare
tihuan
approved these changes
Oct 3, 2022
Bento007
added a commit
that referenced
this pull request
Oct 4, 2022
* hide navbar when seamless not enabled * update smoke tests and refactor some components for typescript * remove comment Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]>
Bento007
added a commit
that referenced
this pull request
Oct 6, 2022
* hide navbar when seamless not enabled * update smoke tests and refactor some components for typescript * remove comment Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#460
#478
Some datasets (e.g. on the covid19 atlas portal) are living on CZI infra but not hosted by the data portal. These should not have the unified navigation bar displayed.
Data portal datasets should all have valid results from the
dataset-metadataendpoint. As a result, any dataset with an invaliddataset-metadataresult will have their nav bars hidden.To ensure tests work properly, dataset metadata and the collections home link page needed to be stubbed. As a result, breadcrumbs smoke tests can now work, so I added them to this PR as well (#478).