Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed issue where config was not generating properly due to CXG version upgrade #492

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Oct 7, 2022

Fixes #491
cxg_dataset.py was not configured to check for version 0.3.0. Version parsing using packaging.version was added to more elegantly parse and compare version strings.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #492 (441dcbf) into main (42e4222) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   74.99%   75.00%           
=======================================
  Files          99       99           
  Lines        7815     7817    +2     
=======================================
+ Hits         5861     5863    +2     
  Misses       1954     1954           
Flag Coverage Δ
frontend 74.99% <100.00%> (+<0.01%) ⬆️
javascript 74.99% <100.00%> (+<0.01%) ⬆️
smokeTest ∅ <ø> (∅)
unitTest 74.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/dataset/cxg_dataset.py 84.86% <100.00%> (+0.04%) ⬆️
dataset/cxg_dataset.py 84.86% <0.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seve seve self-requested a review October 7, 2022 16:35
@atarashansky atarashansky merged commit e0500d7 into main Oct 7, 2022
@atarashansky atarashansky deleted the atar/fix-dataset-metadata branch October 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default embeddings is not showing up in Explorer
2 participants