fix: eb dir -> ecs dir #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbe3e1e.
Codecov Report
@@ Coverage Diff @@
## main #524 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 91 91
Lines 7095 7095
=======================================
Hits 5561 5561
Misses 1534 1534
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atolopko-czi
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Rubber-stamp approval, noting that I'm no longer sure what works and what doesn't w.r.t. ECS deployment needs. It does appear that previously removed files were okay to remove, but there was just a few fixes needed here to reference the new ecs dir correctly.
Bento007
reviewed
Oct 27, 2022
|
|
||
|
|
||
| # Bundles the application so that it can be dockerized and run in ECS | ||
| .PHONY: build-ecs |
There was a problem hiding this comment.
isn't this used on line 32 of the dockerfiles
There was a problem hiding this comment.
No, I left build-ecs inside the ecs folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.