-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deployed_version endpoint #588
Conversation
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 78.40% 78.45% +0.05%
==========================================
Files 84 84
Lines 6594 6610 +16
==========================================
+ Hits 5170 5186 +16
Misses 1424 1424
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test for this endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's also add a simple test to test_api_v3.py
, to keep code coverage from falling.
Also note that I added a follow-up task to the issue to update the deployment checklist.
I will add a test, but note that it won't guarantee the endpoint to work since it's environment/infra dependent. |
…kerberg/single-cell-explorer into ebezzi/deployed-version-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Can this be merged? |
#582
Adds a
deployed_version
endpoint.