Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deployed_version endpoint #588

Merged
merged 8 commits into from
May 16, 2023
Merged

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Apr 12, 2023

#582
Adds a deployed_version endpoint.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #588 (2f6588f) into main (4e30db8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 2f6588f differs from pull request most recent head 01c43d0. Consider uploading reports for the commit 01c43d0 to get more accurate results

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   78.40%   78.45%   +0.05%     
==========================================
  Files          84       84              
  Lines        6594     6610      +16     
==========================================
+ Hits         5170     5186      +16     
  Misses       1424     1424              
Flag Coverage Δ
frontend 78.45% <100.00%> (+0.05%) ⬆️
javascript 78.45% <100.00%> (+0.05%) ⬆️
unitTest 78.45% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/app/api/v3.py 97.36% <100.00%> (+0.07%) ⬆️
server/common/rest.py 81.00% <100.00%> (+0.29%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Bento007 Bento007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for this endpoint

Copy link
Contributor

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's also add a simple test to test_api_v3.py, to keep code coverage from falling.

Also note that I added a follow-up task to the issue to update the deployment checklist.

@ebezzi
Copy link
Member Author

ebezzi commented Apr 14, 2023

I will add a test, but note that it won't guarantee the endpoint to work since it's environment/infra dependent.

ebezzi added 2 commits April 14, 2023 09:51
…kerberg/single-cell-explorer into ebezzi/deployed-version-endpoint
@ebezzi ebezzi requested a review from atolopko-czi April 14, 2023 19:18
Copy link
Contributor

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@metakuni
Copy link
Contributor

Can this be merged?

@ebezzi ebezzi enabled auto-merge (squash) May 10, 2023 19:29
@Bento007 Bento007 disabled auto-merge May 11, 2023 23:42
@Bento007 Bento007 enabled auto-merge (squash) May 11, 2023 23:42
@Bento007 Bento007 disabled auto-merge May 11, 2023 23:42
@Bento007 Bento007 enabled auto-merge (squash) May 11, 2023 23:43
@Bento007 Bento007 merged commit 64b4979 into main May 16, 2023
@Bento007 Bento007 deleted the ebezzi/deployed-version-endpoint branch May 16, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants