Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail happy deploy if service does not start successfully #663

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

danieljhegeman
Copy link

@danieljhegeman danieljhegeman commented Sep 26, 2023

See issue description.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #663 (02da2ad) into main (7157144) will not change coverage.
The diff coverage is n/a.

❗ Current head 02da2ad differs from pull request most recent head a1d58dc. Consider uploading reports for the commit a1d58dc to get more accurate results

@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files          88       88           
  Lines        6772     6772           
=======================================
  Hits         5260     5260           
  Misses       1512     1512           
Flag Coverage Δ
frontend 77.67% <ø> (ø)
javascript 77.67% <ø> (ø)
smokeTest ?
unitTest 77.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@danieljhegeman danieljhegeman merged commit 7796ef7 into main Sep 26, 2023
@danieljhegeman danieljhegeman deleted the dan/662-happy-deploy branch September 26, 2023 17:57
danieljhegeman pushed a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants