Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add types for recognized version commit #81

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Sep 22, 2021

Reviewers

Functional:
@seve

Readability:
@ebezzi

Changes

Added types!

Thanks all 🙏

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #81 (41d1732) into main (6536f05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         126      126           
  Lines       10084    10084           
=======================================
  Hits         7244     7244           
  Misses       2840     2840           
Flag Coverage Δ
frontend 71.83% <ø> (ø)
javascript 71.83% <ø> (ø)
unitTest 71.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6536f05...41d1732. Read the comment docs.

@tihuan tihuan merged commit e807dca into main Sep 23, 2021
@tihuan tihuan deleted the thuang-patch-recognized-versions branch September 23, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants